Improve Term documentation #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x-hgg-x
commented
Oct 28, 2024
|
I personally like the suggested changes. Thank you @x-hgg-x |
x-hgg-x
force-pushed
the
term-doc
branch
2 times, most recently
from
54d11ab
to
3e29e99
Compare
|
@konstin you are the one most recently working to understand this so I leave the final decision to you. |
konstin
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
I'll wait till you converge on #264 (comment), otherwise r+ from me
auto-merge was automatically disabled
October 29, 2024 19:59
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds better documentation for
Term, clarifies the difference betweenPositive(r)andNegative(r.complement()), and adds justifications forTermmathematical operations.