Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another attempt at appending Git SHA to version number in Insider builds #610

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Another attempt at appending Git SHA to version number in Insider builds #610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions .github/workflows/insiders-build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ jobs:
include:
- os: win-code-sign
build: |
# Inject git SHA into package.json
$GIT_SHA = (git rev-parse --short HEAD)
(Get-Content package.json) -replace '"version": "(.*?)"', '"version": "`$1-$GIT_SHA"' | Set-Content package.json

./node_modules/.bin/esbuild src/ctrl-q.js --bundle --outfile=build.cjs --format=cjs --platform=node --target=node23 --inject:./src/lib/util/import-meta-url.js --define:import.meta.url=import_meta_url
node --experimental-sea-config sea-config.json
node -e "require('fs').copyFileSync(process.execPath, 'ctrl-q.exe')"
Expand Down Expand Up @@ -63,7 +67,10 @@ jobs:
artifact_insider: ctrl-q--win-x64--${{ github.sha }}.zip
- os: mac-build1
build: |
# -------------------
# Inject git SHA into package.json
GIT_SHA=$(git rev-parse --short HEAD)
sed -i '' "s/\"version\": \".*\"/\"version\": \"4.4.0-$GIT_SHA\"/" package.json

./node_modules/.bin/esbuild src/ctrl-q.js --bundle --outfile=build.cjs --format=cjs --platform=node --target=node23 --inject:./src/lib/util/import-meta-url.js --define:import.meta.url=import_meta_url
node --experimental-sea-config sea-config.json
cp $(command -v node) ${DIST_FILE_NAME}
Expand Down Expand Up @@ -125,6 +132,10 @@ jobs:

- os: ubuntu-latest
build: |
# Inject git SHA into package.json
GIT_SHA=$(git rev-parse --short HEAD)
sed -i "s/\"version\": \".*\"/\"version\": \"4.4.0-$GIT_SHA\"/" package.json

./node_modules/.bin/esbuild src/ctrl-q.js --bundle --outfile=build.cjs --format=cjs --platform=node --target=node23 --inject:./src/lib/util/import-meta-url.js --define:import.meta.url=import_meta_url
node --experimental-sea-config sea-config.json
cp $(command -v node) ${DIST_FILE_NAME}
Expand Down Expand Up @@ -156,11 +167,6 @@ jobs:
pwd
npm ci --include=prod

- name: Inject git SHA into package.json
run: |
GIT_SHA=$(git rev-parse --short HEAD)
jq --arg sha "$GIT_SHA" '.version += "-" + $sha' package.json > tmp.$$.json && mv tmp.$$.json package.json

- name: Run Snyk to check for vulnerabilities
if: |
github.repository_owner == 'ptarmiganlabs' &&
Expand Down
Loading