Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use packageRequirement in shader files #25

Closed
ahmidou opened this issue Jan 6, 2022 · 1 comment
Closed

use packageRequirement in shader files #25

ahmidou opened this issue Jan 6, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@ahmidou
Copy link

ahmidou commented Jan 6, 2022

compiling using the builtin pipeline gives errors because of the subshaders for universal and HD render pipeline.
you can add PackageRequirements that way in PassesUniversal.hlsl and DearImGui-Procedural.shader to overcome the issue

    // shader for HD render pipeline
    SubShader
    {
        Tags { "RenderType" = "Transparent" "RenderPipeline" = "HDRenderPipeline" "PreviewType" = "Plane" }
        LOD 100

        Lighting Off
        Cull Off ZWrite On ZTest Always
        Blend SrcAlpha OneMinusSrcAlpha

        Pass
        {
            PackageRequirements {
                "com.unity.render-pipelines.high-definition"
            }
            Name "DEARIMGUI HDRP"

            HLSLPROGRAM
            #pragma vertex ImGuiPassVertex
            #pragma fragment ImGuiPassFrag
            #include "./PassesHD.hlsl"
            ENDHLSL
        }
    }
@psydack psydack self-assigned this Jan 13, 2022
@psydack psydack added the enhancement New feature or request label Jan 13, 2022
@psydack
Copy link
Owner

psydack commented Jan 13, 2022

Awesome. That's a must and requested feature.
Thank you

psydack pushed a commit that referenced this issue Jan 13, 2022
@psydack psydack closed this as completed Jan 13, 2022
psydack added a commit that referenced this issue Jan 14, 2022
fix: #25 use packageRequirements suggestion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants