Try to switch pkg-config (works on OpenSUSE) #1315
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvarrazzo
reviewed
Jul 2, 2021
| elif attr_name == "ldflags": | ||
| process = "{} --libs-only-L libpq".format(self.pkg_config_exe) | ||
| elif attr_name == "cppflags": | ||
| process = "{} --cflags libpq".format(self.pkg_config_exe) |
There was a problem hiding this comment.
I am sorry but this is really not something that I wish to accept. Depending on so many external tool is nothing I wish to maintain. The pg_config exists exactly to avoid this.
If you provide a patch so that, calling pg_config --what it looks for an env var PG_CONFIG_WHAT and uses it in preference then we might consider it. Then Suse or whatever else think it's a good idea could create an external wrapper using cut, sed, awk, perl, or whatever bashism to call setup.py.
|
Closing as the proposed approach is not portable nor maintainable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.