Get rid of unwrap() for array parsing in generated code #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generated code for parsing an array first got a slice of the expected length and then used the TryFrom trait to get an array. For example: let (data1, remaining) = crate::x11_utils::parse_u8_list(remaining, 24)?; let data1 = <[u8; 24]>::try_from(data1).unwrap(); This commit introduces a helper function that produces an array directly. The above becomes: let (data1, remaining) = crate::x11_utils::parse_u8_array::<24>(remaining)?; The goal here is to remove some unwrap()s in the generated code, but this also helps shortening the code. There are two new helper function: parse_u8_array parses an array while parse_u8_array_ref returns a reference to an array. Both cases are needed in the generated code. Signed-off-by: Uli Schlachter <psychon@znc.in>
Codecov ReportBase: 13.66% // Head: 13.67% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #781 +/- ##
=======================================
Coverage 13.66% 13.67%
=======================================
Files 142 142
Lines 120042 120012 -30
=======================================
+ Hits 16404 16407 +3
+ Misses 103638 103605 -33
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
eduardosm
approved these changes
Dec 29, 2022
|
For future reference, |
|
Ah, nice. Thanks. I added that to #538. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated code for parsing an array first got a slice of the expected length and then used the TryFrom trait to get an array. For example:
This commit introduces a helper function that produces an array directly. The above becomes:
The goal here is to remove some unwrap()s in the generated code, but this also helps shortening the code.
There are two new helper function: parse_u8_array parses an array while parse_u8_array_ref returns a reference to an array. Both cases are needed in the generated code.
Signed-off-by: Uli Schlachter psychon@znc.in