Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'--ignore-replicated' is not ignoring replicated #95

Closed
xrobau opened this issue Sep 15, 2021 · 1 comment
Closed

'--ignore-replicated' is not ignoring replicated #95

xrobau opened this issue Sep 15, 2021 · 1 comment

Comments

@xrobau
Copy link
Contributor

xrobau commented Sep 15, 2021

I can't reopen #93 but this is the same problem.

As --ignore-replicated is actually looking at CHANGES, not the 'replicated' source, if a backup starts, and a volume is in the process of being received, it will be marked for backup.

Will you accept a pull request for --really-ignore-replicated if you believe the current logic is correct?
@xrobau
Copy link
Contributor Author

xrobau commented Sep 16, 2021

As I was about to write the code, I noticed it already existed, and was just not documented!

@psy0rz psy0rz closed this as completed in 2ba6fe5 Sep 16, 2021
psy0rz added a commit that referenced this issue Sep 16, 2021
@psy0rz
Merge pull request #96 from xrobau/really-ignore-replicated
f9b16c0 
Fix #93, Fix #95 Re-Document --exclude-received
psy0rz added a commit that referenced this issue Sep 20, 2021
@psy0rz
renamed --ignore-replicated to --exclude-unchanged. tidied up and rem…
578fb1b 
…oved seperate filter_replicated() step. #93, #95, #96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xrobau