Refactored to make the renewal response from Sirsi uniform. #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
banukutlu
reviewed
Jan 27, 2020
banukutlu
suggested changes
Jan 27, 2020
Co-Authored-By: Banu Hapeloglu Kutlu <bzk60@psu.edu>
banukutlu
suggested changes
Jan 27, 2020
Co-Authored-By: Banu Hapeloglu Kutlu <bzk60@psu.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was thinking that we could make the renewal response uniform so that we can reduce the complexity of the code in the controller.
A step further to me would be to turn this uniform hash into a small class like SirsiRenewalResponse.