Java Connector Update, Javascript Async Handling #21

gmkll · 2016-08-05T10:07:42Z

JAVA

create interface, abstract classes
adapt Java Download for RichFileManager and content type fixes

JS

init methods and loading changed to async behaviour using deferred jquery objects
use a local data holder object 'fm'

- added interface FileManagerI and abstract class AbstractFM and optional class RichFileManager - the only changes in RichFileManager are proper download handling and thumbnail setting instead preview - TODO: upload, ..? UPDATED - fixed content type handling in JSP files - in scripts/filemanager.js add async ajax calls and global object FileManager

- moved Filemanager to local scope and renamed it to fm in filemanager.js

- JAVA: support upload and replace - JS: fileroot handling?

psolom · 2016-08-05T19:47:10Z

scripts/filemanager.js

 		loadJS('/scripts/CodeMirror/lib/codemirror.js');
 		loadJS('/scripts/CodeMirror/addon/selection/active-line.js');
 		loadCSS('/scripts/CodeMirror/addon/display/fullscreen.css');
 		loadJS('/scripts/CodeMirror/addon/display/fullscreen.js');
 		loadJS('/scripts/CodeMirror/dynamic-mode.js');
 	}
+
+  // added gk from simogeo, why was it removed?


Of the initial ideas of the current FM implementation is to divide client-side and server-side setting as much as possible. So "fileRoot" option now relative to the path returned in server response and doesn't depend on "serverRoot" option. So this part can be removed indeed.

that seems a good idea, this would change probably client and server side, I ll update the master, if done.

Yes, you could pull new changes from master.
Also read this topic, please. It's about new features of "Preview" and "Thumbnail" params in response to "getinfo" request. The solution, that we came to, is implemented and is on master.

I read it, ok I try to provide an updated version tomorrow, with merged in changes from PR #23. CU

psolom · 2016-08-08T11:29:00Z

scripts/filemanager.js

+      },
+      axis: "yx"
+      });
+


I tested upload and replace file(s), which seem to work now, although fileTree refresh seems not .. another TODO

Don't worry much about filetree. I'm going to replace it with another, more flexible, plugin and I have started to implement it already.

* JAVA - moveItem fixes - allow relative docroot (file_root in JS) - prepare getInfo behaviour (TODO) - optional reload * JS - fileTree loading fixed - liveupdate dynamic fix (in adjustFileTree) - removed fileRoot handling

Fix Issue psolom#27 and merging changes PR psolom#18.

fabriceci · 2016-08-09T14:03:14Z

HI @gmkll , we worked on a java connector at the same time. I think my connector is in a more advanced stage, I use for now with Spring MVC. It needs little changes (noe need to specify path with JSP). Can we discuss about this and maybe merge our work?

gmkll · 2016-08-09T15:00:16Z

Of course, let´s discuss! As we are using simogeo fileManager for quite a while with JSP connector, I looked for an update, and thought I could achieve with a little effort to get it to work, i.e. just with the basic functionality (e.g. no editing). Now, I hope with this PR the JSP backend IS (almost?) working.

Wouldn´t be the best idea to add yours as an another, a real "java" connector and keeping the jsp connector as a lightweighted version (question also to @servocoder)? For our purposes this is exactly, what we need, at least for the moment.

fabriceci · 2016-08-09T18:31:12Z

I just checked quickly the state of the connector (to know if I continue mine or not).

In my opinion, the Java connector should provide the same functionalities as the PHP one (including security settings, upload, thumbnails, edit, etc.). In the best case, people should just put the jar in their projects (no need to compile the class).

I don’t think it's a good idea to have 2 different connectors (one light and one complete), but in the other hand, I use some JAVA 7's functionalities, if still people using JAVA 6 this can be a problem. (I don't know if you still work with 1.6).

Maybe, before to go further in the conversation, I should show you what I have done. I will put the connector in a repo in the coming days. (It’s still not finished and I must try with a simple jsp project), but the code is very close.

psolom · 2016-08-09T19:06:20Z

Thanks you both for your efforts on Java connector.

I agree that Java connector should provide the same (or as close as possible) functionalities as the PHP connector. PHP connector is always up to date with new features and options from config file, we should consider it as a standard model of a connector. So let's try to implement Java connector trying to involve as much features as possible.

Shall we create 2 Java connectors? I'm not aware of distinctions of Java versions and frameworks. You know this stuff better than I do. The only thing I can say is that it will be harder to maintain 2 connectors instead of one. Keep it in mind while taking a decision.

psolom · 2016-08-11T06:51:03Z

scripts/filemanager.js

 (function($) {
+
+  // keep variables in non global object
+var fm = {};


I believe this object is redundant.
All variables defined inside (function($) { }) exist in the scope of that function and they aren't accessible in the global scope. Vice versa - variables defined inside (function($) { }) aren't going to overwrite global variables for some other scope. You could simply check it if you invoke config or lg variable in a debug console of your browser FM is inited. They are undefined, in case you don't have globals defined with the same name of course.

So I can't see any benefit from the fm object. Only the headache to add it for the each variable defined in the FM scope. Update your PR and remove it, if you don't have any reasonable objections, please.

you are right. I initially thought it a good idea, to have one globalcontext, but I moved the fm-variable into function context, it would be just helpful to have it as a data holder object - to check all the variables, which FM is using and to easily switch context, of course. But if you think it´s better without (the reference chain is of course longer), I can remove it and update the PR.

I have got your point. Indeed, it's more flexible to change context if you have all variables under the context of a single object. I don't care of a reference chain length actually, but I'm worry a bit not to miss any variable being added to vm object. Well, let's postpone the decision on that.

gmkll · 2016-08-12T09:46:52Z

Hi @servocoder, @fabriceci,

my approach is so far to improve the connector step by step - I am aware of, that a lot is missing, e.g config is currently read from local config.properties only, not from provided connector config file, etc. The code is mainly just a fix of the old connector!

Using spring is of course nice, but, if your webapp is not already using spring, you have to think about (a lot of) dependencies (spring-context is about 3MB - do you need other spring resources?). Actually server side configuration could be resolved rather elegantly, though.

For now, the non servlet dependencies are commons.fileupload, and org.slf4j, which should be provided (I could add an pom.xml to automatically build a jar).

Java 7 - I already use the new java.nio mechanism!

The PR is actually twofold: JSP connector and JS deferred mode/data holder object, which are almost independent from each other - I suggest to merge both (next week) and proceed from there in small(er) steps rather than to do a big shot. The PR stuff is in beta already tested positively and up to now is working positively.

May be, @servocoder, you want to contact the other Java Connector Committer or ask others ??

psolom · 2016-08-12T10:24:02Z

Hi @gmkll, @fabriceci
I am going to merge changes of the PR at the weekend. I don't mind to have 2 Java related connectors if they are different in a many aspects. Actually I have decided to go in this way. Both of you are familar with Java and utilize a variety of tools and different versions. No problem. Let's create one more new connector for Spring MVC. In this way we are going to provide an extended choice of Java backends to the user on the one hand and each of you will be able to maintain any of both Java connectors on the other, aren't you?

psolom · 2016-08-12T10:29:19Z

Btw, @th-schwarz have been already notified of this thread.
He is the developer of the original Java backend for the FM at @simogeo repo. Perhaps he would like to join to you.

fabriceci · 2016-08-12T11:31:01Z

@gmkll

You misunderstood, I said I use Java Spring MVC because I need to overload some parameters (and because I don't try with JSP).

Like I said, the connector's code is very close to yours, with :

same functions as the php connector
ability to overload some parameters (like baseUrl)
turn the code much closer as the php one

There is no dependencies related to spring, I will put my connector in a repo, we will be able then, to decide what we do, if you are agree.

@servocoder given that the java version is the same, there is no need to have 2 connectors.

psolom · 2016-08-16T07:27:57Z

@gmkll, please update your PR to the last changes desribed in #31 and will merge your commit. Thank you.

gmkll · 2016-08-16T08:58:24Z

I´ll update, but could you review #34 and update the Wiki, that I´ll better understand, what´s the current state? Expect some delay, until I fully grasp things and change duly. Thanks!

psolom · 2016-08-16T13:32:38Z

The API have been updated. It's how it works now, but I am going to make it more standartized soon. I believe it won't require some global changes, so it shouldn't be an impediment for you to keep moving on your connector.

Also I would ask you to remove fm object for now. I have some thoughts about how to keep the FM plugin, I perhaps go further and make some of FM functions public and so on. So it will be changed anyway.

psolom · 2016-08-16T15:04:59Z

FYI. All the logic to build path/url for Preview and Thumbnail params was moved from connector to the client-side. You can take a look at get_file_info method in the PHP connector and compare the latest version with the one before commit. So now it becomes more simplier for ones who work on connectors. You just need to return Path param like for other requests (see in API)

UPDATE JAVA - Removed Thumbnail and Preview properties, use Path only - client path as a URL from context reading preview config, server path from doc_root conf property, both should work either relative or absolute. TODO Bugfix in fm.js: createPreviewUrl would only need to be "/" + path, no call to connector JS - removed global object, merged PHP, images - merged without changes

JAVA - support readfile mode - remove preview filtering/mapping, but keep/provide the empty wrappers to allow for extending and first step hint for implementation, cft. issue psolom#27 and psolom#31

JAVA - fix path resolution, if not yet implemented

psolom · 2016-08-31T08:15:35Z

Thanks a lot, you choud try it on dev branch, check #41

Georg Kallidis added 4 commits August 4, 2016 16:48

UPDATE

9d4ade2

- moved Filemanager to local scope and renamed it to fm in filemanager.js

Typo in comment

965458f

gmkll mentioned this pull request Aug 5, 2016

ParentFolder should not submit simogeo/Filemanager#504

Open

UPDATE

d42d036

- JAVA: support upload and replace - JS: fileroot handling?

psolom reviewed Aug 5, 2016
View reviewed changes

psolom mentioned this pull request Aug 7, 2016

Feature request: roles management (multi-profile) #24

Closed

psolom reviewed Aug 8, 2016
View reviewed changes

UPDATE

c001f0f

* JAVA - moveItem fixes - allow relative docroot (file_root in JS) - prepare getInfo behaviour (TODO) - optional reload * JS - fileTree loading fixed - liveupdate dynamic fix (in adjustFileTree) - removed fileRoot handling

gmkll mentioned this pull request Aug 9, 2016

Question related to the preview/path and possible improvements #18

Closed

Merge remote-tracking branch 'upstream/master'

dfc7fdd

Fix Issue psolom#27 and merging changes PR psolom#18.

psolom reviewed Aug 11, 2016
View reviewed changes

This was referenced Aug 11, 2016

nodejs connector #30

Closed

Road map for coordination simogeo/Filemanager#456

Open

psolom added this to the 1.1.0 milestone Aug 16, 2016

gmkll mentioned this pull request Aug 16, 2016

Client and Server parts separation. Better API support. #31

Closed

gmkll mentioned this pull request Aug 17, 2016

createPreviewUrl dynamic path and normalize path bug #27

Closed

Georg Kallidis added 2 commits August 18, 2016 11:52

UPDATE

ac489a5

JAVA - support readfile mode - remove preview filtering/mapping, but keep/provide the empty wrappers to allow for extending and first step hint for implementation, cft. issue psolom#27 and psolom#31

UPDATE

e46e5c2

JAVA - fix path resolution, if not yet implemented

psolom merged commit 6a094bb into psolom:master Aug 31, 2016

psolom mentioned this pull request Aug 31, 2016

Release 1.1 roadmap #41

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Java Connector Update, Javascript Async Handling #21

Java Connector Update, Javascript Async Handling #21

gmkll commented Aug 5, 2016

psolom Aug 5, 2016

gmkll Aug 8, 2016

psolom Aug 8, 2016

gmkll Aug 8, 2016

psolom Aug 8, 2016

fabriceci commented Aug 9, 2016

gmkll commented Aug 9, 2016

fabriceci commented Aug 9, 2016 •

edited

Loading

psolom commented Aug 9, 2016 •

edited

Loading

psolom Aug 11, 2016

gmkll Aug 11, 2016

psolom Aug 11, 2016 •

edited

Loading

gmkll commented Aug 12, 2016

psolom commented Aug 12, 2016

psolom commented Aug 12, 2016

fabriceci commented Aug 12, 2016 •

edited

Loading

psolom commented Aug 16, 2016

gmkll commented Aug 16, 2016

psolom commented Aug 16, 2016

psolom commented Aug 16, 2016

psolom commented Aug 31, 2016 •

edited

Loading

Java Connector Update, Javascript Async Handling #21

Java Connector Update, Javascript Async Handling #21

Conversation

gmkll commented Aug 5, 2016

psolom Aug 5, 2016

Choose a reason for hiding this comment

gmkll Aug 8, 2016

Choose a reason for hiding this comment

psolom Aug 8, 2016

Choose a reason for hiding this comment

gmkll Aug 8, 2016

Choose a reason for hiding this comment

psolom Aug 8, 2016

Choose a reason for hiding this comment

fabriceci commented Aug 9, 2016

gmkll commented Aug 9, 2016

fabriceci commented Aug 9, 2016 • edited Loading

psolom commented Aug 9, 2016 • edited Loading

psolom Aug 11, 2016

Choose a reason for hiding this comment

gmkll Aug 11, 2016

Choose a reason for hiding this comment

psolom Aug 11, 2016 • edited Loading

Choose a reason for hiding this comment

gmkll commented Aug 12, 2016

psolom commented Aug 12, 2016

psolom commented Aug 12, 2016

fabriceci commented Aug 12, 2016 • edited Loading

psolom commented Aug 16, 2016

gmkll commented Aug 16, 2016

psolom commented Aug 16, 2016

psolom commented Aug 16, 2016

psolom commented Aug 31, 2016 • edited Loading

fabriceci commented Aug 9, 2016 •

edited

Loading

psolom commented Aug 9, 2016 •

edited

Loading

psolom Aug 11, 2016 •

edited

Loading

fabriceci commented Aug 12, 2016 •

edited

Loading

psolom commented Aug 31, 2016 •

edited

Loading