Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change in test_requests.py #6873

Closed
wants to merge 1 commit into from
Closed

change in test_requests.py #6873

wants to merge 1 commit into from

Conversation

saksham-sak
Copy link

add some changes in file line from 707

sigmavirus24
sigmavirus24 requested changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@sigmavirus24 sigmavirus24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be no reason to make these changes. Why do you feel they're necessary? Can you please better describe what you're trying to achieve?

@saksham-sak
Copy link
Author

the changes made to the original code is to ensure robustness and reliability by proactively handling potential errors and edge cases.

@hugovk
Copy link
Contributor

hugovk commented Jan 28, 2025 •
edited
Loading

This looks like time-wasting AI slop, much like psf/the-invisibles#53 and psf/policies#18 (comment).

@hugovk hugovk mentioned this pull request Jan 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigmavirus24 sigmavirus24 sigmavirus24 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saksham-sak @hugovk @sigmavirus24 @sethmlarson