Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade urllib3 to 490d3a227fadb626cd54a240b9d0922f849914b4 #2444

Merged
merged 1 commit into from
Feb 23, 2015

Conversation

Yasumoto
Copy link
Contributor

This is the release tagged at 85dfc16817df1e3604c238ad5d64f3b229e0598b

@Yasumoto
Copy link
Contributor Author

Tested on OS X 10.10:

[tw-mbp-jsmith requests (urllib_upgrade)]$ make test
# This runs all of the tests. To run an individual test, run py.test with
# the -k flag, like "py.test -k test_path_is_not_double_encoded"
py.test test_requests.py
============================================================================== test session starts ===============================================================================
platform darwin -- Python 2.7.9 -- pytest-2.3.4
plugins: cov
collected 154 items 

test_requests.py ..........................................................................................................................................................

========================================================================== 154 passed in 26.34 seconds ===========================================================================

This is to get urllib3/urllib3#526 merged in pypa/pip#2395 can take advantage of the fix for older SSL library versions. This was previously tracked at https://github.com/kennethreitz/requests/issues/2435.

@sigmavirus24
Copy link
Contributor

We actually will pull in tip when we do a release. Speaking of which @Lukasa when do you think we should do a release? There's extra header awesomeness that's unreleased in urllib3 (merged last night) that I'd like to grab before doing a release.

@Yasumoto
Copy link
Contributor Author

@sigmavirus24 sounds good- I updated to HEAD, but feel free to drop this PR in favor of another one if this is in flight elsewhere.

@sigmavirus24 sigmavirus24 changed the title Upgrade urllib3 to 1.10.1 Upgrade urllib3 to 490d3a227fadb626cd54a240b9d0922f849914b4 Feb 11, 2015
@bcail
Copy link

bcail commented Feb 16, 2015

It'd be great to get a bug-fix release soon (for issue #2435), so that we can use requests on python 2.7.9...

@Yasumoto
Copy link
Contributor Author

Howdy all, anything I can do to help get this over the finish line? Happy to pitch in on testing or updating docs for 'upgrading urllib3' if I missed something too.

Thanks!!

@patsoffice
Copy link

This is a pretty big blocker for me right now. Any chance we can get this pull request merged soon?

sigmavirus24 added a commit that referenced this pull request Feb 23, 2015
Upgrade urllib3 to 490d3a227fadb626cd54a240b9d0922f849914b4
@sigmavirus24 sigmavirus24 merged commit 0b6d2e4 into psf:master Feb 23, 2015
@Yasumoto
Copy link
Contributor Author

Thanks @sigmavirus24 !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants