Skip to content

Commit

Permalink
Top PyPI Packages: Use 30-days data, 365 is no longer available (#2995)
Browse files Browse the repository at this point in the history
  • Loading branch information
hugovk authored Apr 6, 2022
1 parent 421383d commit 9b30740
Showing 1 changed file with 5 additions and 8 deletions.
13 changes: 5 additions & 8 deletions gallery/gallery.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,9 @@
from concurrent.futures import ThreadPoolExecutor
from functools import lru_cache, partial
from pathlib import Path
from typing import ( # type: ignore # typing can't see Literal
from typing import (
Generator,
List,
Literal,
NamedTuple,
Optional,
Tuple,
Expand All @@ -24,12 +23,11 @@

PYPI_INSTANCE = "https://pypi.org/pypi"
PYPI_TOP_PACKAGES = (
"https://hugovk.github.io/top-pypi-packages/top-pypi-packages-{days}-days.json"
"https://hugovk.github.io/top-pypi-packages/top-pypi-packages-30-days.min.json"
)
INTERNAL_BLACK_REPO = f"{tempfile.gettempdir()}/__black"

ArchiveKind = Union[tarfile.TarFile, zipfile.ZipFile]
Days = Union[Literal[30], Literal[365]]

subprocess.run = partial(subprocess.run, check=True) # type: ignore
# https://github.com/python/mypy/issues/1484
Expand Down Expand Up @@ -64,8 +62,8 @@ def get_pypi_download_url(package: str, version: Optional[str]) -> str:
return cast(str, source["url"])


def get_top_packages(days: Days) -> List[str]:
with urlopen(PYPI_TOP_PACKAGES.format(days=days)) as page:
def get_top_packages() -> List[str]:
with urlopen(PYPI_TOP_PACKAGES) as page:
result = json.load(page)

return [package["project"] for package in result["rows"]]
Expand Down Expand Up @@ -128,13 +126,12 @@ def get_package(

def download_and_extract_top_packages(
directory: Path,
days: Days = 365,
workers: int = 8,
limit: slice = DEFAULT_SLICE,
) -> Generator[Path, None, None]:
with ThreadPoolExecutor(max_workers=workers) as executor:
bound_downloader = partial(get_package, version=None, directory=directory)
for package in executor.map(bound_downloader, get_top_packages(days)[limit]):
for package in executor.map(bound_downloader, get_top_packages()[limit]):
if package is not None:
yield package

Expand Down

0 comments on commit 9b30740

Please sign in to comment.