Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix device Type V3 #81

Merged

Conversation

FabianKielkopf
Copy link
Contributor

Added support for new Devices (Gen 3 Nuki Startlocks).

@c0ffee
Copy link

c0ffee commented Mar 17, 2022

+1

Copy link
Owner

@pschmitt pschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to have a default value set for device_type so that this is less of a breaking change.
Other than that: LGTM, thanks!

@mi1os
Copy link

mi1os commented Aug 4, 2022

hey guys, can we please merge this? can I help with it somehow?

@pvizeli
Copy link

pvizeli commented Mar 21, 2023

Yeah, would be nice to having it

@pschmitt pschmitt merged commit 79a6219 into pschmitt:main Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants