Specific imports instead of wild card (GEOUNED-org#100)

* improved import statements flake8 hints * removed extra line
psauvan · Apr 26, 2024 · bf061fa · bf061fa
1 parent 12ec904
commit bf061fa
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 3 deletions.
diff --git a/src/geouned/GEOReverse/Modules/MCNPinput.py b/src/geouned/GEOReverse/Modules/MCNPinput.py
@@ -6,7 +6,21 @@
 import numpy as np
 from numpy import linalg as LA
 
-from .Objects import *
+from .Objects import (
+    CadCell,
+    Plane,
+    Sphere,
+    Cylinder,
+    Cone,
+    EllipticCone,
+    Hyperboloid,
+    Ellipsoid,
+    EllipticCylinder,
+    HyperbolicCylinder,
+    Paraboloid,
+    Torus,
+    Box,
+)
 from .Parser import parser as mp
 from .remh import CellCardString, remove_hash
 

diff --git a/src/geouned/GEOReverse/Modules/XMLinput.py b/src/geouned/GEOReverse/Modules/XMLinput.py
@@ -7,7 +7,7 @@
 import numpy as np
 from numpy import linalg as LA
 
-from .Objects import *
+from .Objects import CadCell, Plane, Sphere, Cylinder, Cone, Torus
 from .XMLParser import get_cards
 
 

diff --git a/src/geouned/__init__.py b/src/geouned/__init__.py
@@ -4,7 +4,7 @@
 # found by subsequent import statements through out the code base
 try:
     import freecad
-except:
+except ImportError:
     pass
 
 from .GEOUNED import *