Update Connection.phpstub

[VincentLanglet]

Phpdoc was taken from https://github.com/doctrine/dbal/blob/3.3.x/src/Connection.php

[orklah]

Well, either this is a direct copy and our stubs should be dropped (at least for this version of doctrine) or there are still cases where this plugin is more precise than doctrine and I'm wondering if it's normal to loosen the types we have?

(Please take into account that I don't use doctrine, so maybe the fixes here are obviously right, but I have to ask :p)

[VincentLanglet]

Well, either this is a direct copy and our stubs should be dropped (at least for this version of doctrine) or there are still cases where this plugin is more precise than doctrine and I'm wondering if it's normal to loosen the types we have?

(Please take into account that I don't use doctrine, so maybe the fixes here are obviously right, but I have to ask :p)

I don't really use those method, but recently got an error here: sonata-project/EntityAuditBundle#474

When the phpdoc of the plugin say int[]|string[] but the phpdoc of doctrine explicitly say null or Type values are allowed, I would prefer to believe doctrine than this plugin. Especially because our library always worked like this.

The only difference (and what should be the only goal here) between the stub and doctrine, is the psalm-taint annotation ; so we cannot remove the stub for now.

[orklah]

Seems fine then :)

It makes sense given the recent feedback here too: #106 (comment)