Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code refactor and bug fixes related to bgm. #1444

Closed
wants to merge 6 commits into from
Closed

Code refactor and bug fixes related to bgm. #1444

wants to merge 6 commits into from

Conversation

Wolf3s
Copy link
Contributor

@Wolf3s Wolf3s commented Jan 1, 2025 •
edited
Loading

Pull Request checklist

Note: these are not necessarily requirements

  • I reformatted the code with clang-format
  • I checked to make sure my submission worked
  • I am the author of submission or have permission from the original author
  • Requires update of the PS2SDK or other dependencies
  • Others (please specify below)

Pull Request description

This cleanups and refactors opl as whole.
Changes being made so far:

  • Removed redudant includes
  • Refactored menu.c and audio.c
  • Moved all embedded files to the newly imports.h(extern-irx.h)
  • Fix game launching when bgm is activated.

Size:

Master branch build:
1.337.044 bytes
Cleanup branch build:
1.336.452 bytes

NOTE: There´s a branch that i will push some experiments and with time. I perhaps merge.
Happy new year for all!!!

@Wolf3s Wolf3s force-pushed the Cleanups branch 7 times, most recently from 4b95842 to c563aa2 Compare January 1, 2025 20:44
@Wolf3s
Remove redudant dependencies on opl´s frontend.
f3792c7 
Remove hack code inside of sound.c
@Wolf3s Wolf3s force-pushed the Cleanups branch 9 times, most recently from f3084af to 2940fb7 Compare January 10, 2025 12:17
@Wolf3s Wolf3s marked this pull request as ready for review January 10, 2025 12:34
@Wolf3s Wolf3s closed this Jan 14, 2025
@10522
Copy link

10522 commented Jan 15, 2025

Fix game launching when bgm is activated

@Wolf3s can you please make a test build with this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wolf3s @10522