Outfit wars support #314
Merged
Outfit wars support #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should eventually do something different with the outfit-wars data so that it doesn't appear in the normal active alerts on the website
Updated CreateInstanceOutfitWarsDto and associated entity
Updated outfit wars instance entity to properly use correct index and other props
…alerts by default. Also added to entity. Fixed descriptions for ps2alertsEventType in OW entity
Maelstromeous
commented
Aug 12, 2022
| @@ -0,0 +1,147 @@ | |||
| // import {Inject, Injectable, Logger} from '@nestjs/common'; | |||
There was a problem hiding this comment.
This file shouldn't exist in this PR, my bad
Maelstromeous
commented
Aug 12, 2022
| import {Column} from 'typeorm'; | ||
|
|
||
| export default class OutfitwarsMapControlEmbed { | ||
| @ApiProperty({example: 20, description: 'Team 1 (blue) percentage'}) |
| @@ -43,5 +43,5 @@ export class UpdateFacilityControlDto { | |||
| @IsObject() | |||
| @IsOptional() | |||
| @ApiModelProperty({example: null, default: null}) | |||
| mapControl: MapControlEmbed; | |||
| mapControl: TerritoryControlMapControlEmbed; | |||
There was a problem hiding this comment.
Thinking we should probably prefix this with metagame so it's clear is not OW related, like the rest are
| @IsNotEmpty() | ||
| @IsOptional() | ||
| @ApiModelProperty({example: false, default: false}) | ||
| isInitial: boolean; |
There was a problem hiding this comment.
Potentially can remove
| @ApiOperation({summary: 'Returns a single outfit wars instance'}) | ||
| @ApiResponse({ | ||
| status: 200, | ||
| description: 'The Metagame Instance', |
| return await this.mongoOperationsService.deleteOne(InstanceOutfitWarsTerritoryEntity, {instanceId}); | ||
| } | ||
|
|
||
| @Get('/active') |
| { | ||
| state: Ps2alertsEventState.STARTED, | ||
| world, | ||
| zone, |
There was a problem hiding this comment.
Zone may not be needed here
|
Also adds endpoint to update that instanceId, and converts falcon interface to strings
…e used for search in the future
Tided up various implicit queries
This adds the start time of the next match to the outfits' rankings, and makes the cron job non-destructive to instanceId and createdAt timestamp so it can be run more frequently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards adding support for outfit wars. Closes #312
Tasks
ps2alertsEventTypeps2alertsEventTypemigration to ALL aggregates, giving all current records the value of1(live metagame)