Update Pubsub Parameters #6744
Merged
Update Pubsub Parameters #6744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Where is the reference eth2 PR for this? I think i might have missed it in #6716 EDIT: Found it. It's |
… into updatePubsubParams
terencechain
approved these changes
Jul 29, 2020
Codecov Report
@@ Coverage Diff @@
## master #6744 +/- ##
==========================================
- Coverage 62.30% 62.17% -0.14%
==========================================
Files 386 386
Lines 30064 29924 -140
==========================================
- Hits 18732 18604 -128
+ Misses 8648 8644 -4
+ Partials 2684 2676 -8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Update To Spec
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
Follows on from ethereum/consensus-specs#1958
Part of #6716
Other notes for review