Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update run time to v0.9 #3935

Merged
merged 49 commits into from
Nov 11, 2019
Merged

Update run time to v0.9 #3935

merged 49 commits into from
Nov 11, 2019

Conversation

terencechain
Copy link
Member

@terencechain terencechain commented Nov 6, 2019

This PR merges v0.9 branch to master

What's tested:

  • 1 beacon node 64 validators with eth1 mock rpc
  • 2 beacon nodes 128 validators each with eth1 mock rpc

terencechain and others added 18 commits October 29, 2019 08:44
* rm'ed in protobuf

* build proto

* build proto

* build proto

* fix core package

* Gazelle

* Fixed all the tests

* Fixed static test

* Comment out spec test for now

* One more skip

* fix-roundRobinSync (#3862)

* Starting but need new seed function

* Revert initial sync

* Updated Proposer Slashing

* Fixed all tests

* Lint

* Update inclusion reward

* Fill randao mixes with eth1 data hash

* Test

* Fixing test part1

* All tests passing

* One last test

* Updated config

* Build proto

* Proper skip message

* Conflict and fmt

* Removed crosslinks and shards. Built

* Format and gazelle

* Fixed all the block package tests

* Fixed all the helper tests

* All epoch package tests pass

* All core package tests pass

* Fixed operation tests

* Started fixing rpc test

* RPC tests passed!

* Fixed all init sync tests

* All tests pass

* Fixed blockchain tests

* Lint

* Lint

* Preston's feedback

* Starting

* Remove container

* Fixed block spec tests

* All passing except for block_processing test

* Failing block processing test

* Starting

* Add AggregateAndProof

* All mainnet test passes
* Starting

* Add AggregateAndProof
* rm'ed in protobuf

* build proto

* build proto

* build proto

* fix core package

* Gazelle

* Fixed all the tests

* Fixed static test

* Comment out spec test for now

* One more skip

* fix-roundRobinSync (#3862)

* Starting but need new seed function

* Revert initial sync

* Updated Proposer Slashing

* Fixed all tests

* Lint

* Update inclusion reward

* Fill randao mixes with eth1 data hash

* Test

* Fixing test part1

* All tests passing

* One last test

* Updated config

* Build proto

* Proper skip message

* Conflict and fmt

* Removed crosslinks and shards. Built

* Format and gazelle

* Fixed all the block package tests

* Fixed all the helper tests

* All epoch package tests pass

* All core package tests pass

* Fixed operation tests

* Started fixing rpc test

* RPC tests passed!

* Fixed all init sync tests

* All tests pass

* Fixed blockchain tests

* Lint

* Lint

* Preston's feedback

* Starting

* Remove container

* Fixed block spec tests

* All passing except for block_processing test

* Failing block processing test

* Starting

* Add AggregateAndProof

* All mainnet test passes

* Unskip block util tests
* Starting

* Add AggregateAndProof

* Unskip slot processing mainnet test
* Rm outdated interop tests

* Rm test runner

* Gazelle
@terencechain terencechain self-assigned this Nov 6, 2019
@codecov
Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #3935 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3935   +/-   ##
=======================================
  Coverage   24.39%   24.39%           
=======================================
  Files         161      161           
  Lines       11147    11147           
=======================================
  Hits         2719     2719           
  Misses       8053     8053           
  Partials      375      375

@prestonvanloon
Copy link
Member

Anything still TODO for v0.9?

@terencechain
Copy link
Member Author

terencechain commented Nov 6, 2019

Anything still TODO for v0.9?

Granular local testing like multi nodes with static peers, in the mean time please take a look at this PR for reviews

@nisdas
Copy link
Member

nisdas commented Nov 8, 2019

@terencechain build is failing

@prestonvanloon
Copy link
Member

Just needs #3962 then we can test a deployment.

@prestonvanloon
Copy link
Member

#3962 only affects historical data and is not blocking for testnet release.

@prestonvanloon
Copy link
Member

Blocked by #3965

nisdas and others added 4 commits November 11, 2019 09:29
* copy block

* clone for other service methods too
* change logging of bits

* preston's review
* run test till the end

* fix up proto message types

* fmt

* resolve broken tests

* better error handling

* fixing new logic to use archived proposer info

* fix up logic

* clip using the max effective balance

* broken build fix with num arg mismatch

* amend archive

* archival logic changed

* rename test

* archive both proposer and attester seeds

* page size 100

* further experiments

* further experimentation, archivedProposerIndex seems wrong

* test passes

* rem log

* fix broken test

* fix test

* gaz

* fix imports

* ethapis
@prestonvanloon
Copy link
Member

Ready for final review. This is currently running in testnet

@prestonvanloon
Copy link
Member

Merging at 22:00 UTC (2.5 hours from now) unless any blockers or issues discovered.

Copy link
Contributor

@rauljordan rauljordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through this carefully - excited to have this merged in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants