Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gossipsub parameter test #3200

Merged
merged 5 commits into from
Aug 14, 2019
Merged

Add gossipsub parameter test #3200

merged 5 commits into from
Aug 14, 2019

Conversation

terencechain
Copy link
Member

@terencechain terencechain commented Aug 13, 2019

Part of #3147

This PR ensures gossipsub parameters are compatible with interop. These parameters are the default for libp2p GossipSub. To reduce disparity we also specify these within Prysm to avoid any upstream change breaking interop compatibility...

@terencechain terencechain marked this pull request as ready for review August 13, 2019 23:10
@terencechain terencechain changed the title Add p2p parameter test Add gossipsub parameter test Aug 13, 2019
@codecov
Copy link

codecov bot commented Aug 13, 2019

Codecov Report

Merging #3200 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #3200   +/-   ##
======================================
  Coverage    3.33%   3.33%           
======================================
  Files          30      30           
  Lines        1379    1379           
======================================
  Hits           46      46           
  Misses       1331    1331           
  Partials        2       2

@prestonvanloon prestonvanloon merged commit 072bb4b into master Aug 14, 2019
@delete-merged-branch delete-merged-branch bot deleted the add-parameter-tests branch August 14, 2019 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants