Slot processing spec test

WORKSPACE

@@ -140,7 +140,7 @@ filegroup(
     visibility = ["//visibility:public"],
 )
     """,
-    sha256 = "d297d5df03d1a635450cdb6d746e585485529ce13f121fffc375ad12470ae32f",
+    sha256 = "56847989737e816ab7d23f3bb2422347dfa81271bae81a94de512c01461fab25",
     url = "https://github.com/prysmaticlabs/eth2.0-spec-tests/releases/download/v0.7.1/base64_encoded_archive.tar.gz",
 )
 

beacon-chain/core/blocks/block_operations.go

@@ -103,6 +103,7 @@ func ProcessBlockHeader(
 	if beaconState.Slot != block.Slot {
 		return nil, fmt.Errorf("state slot: %d is different then block slot: %d", beaconState.Slot, block.Slot)
 	}
+
 	parentRoot, err := ssz.SigningRoot(beaconState.LatestBlockHeader)
 	if err != nil {
 		return nil, err

beacon-chain/core/epoch/epoch_processing.go

@@ -940,6 +940,7 @@ func crosslinkDelta(state *pb.BeaconState) ([]uint64, []uint64, error) {
 			}
 		}
 	}
+
 	return rewards, penalties, nil
 }
 

beacon-chain/core/state/spectest/BUILD.bazel

@@ -0,0 +1,28 @@
+load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
+
+go_library(
+    name = "go_default_library",
+    srcs = ["sanity_slots_test.yaml.go"],
+    importpath = "github.com/prysmaticlabs/prysm/beacon-chain/core/state/spectest",
+    visibility = ["//visibility:public"],
+)
+
+go_test(
+    name = "go_default_test",
+    size = "small",
+    srcs = ["slot_processing_test.go"],
+    data = [
+        "@eth2_spec_tests//:test_data",
+    ],
+    embed = [":go_default_library"],
+    tags = ["spectest"],
+    deps = [
+        "//beacon-chain/core/state:go_default_library",
+        "//proto/beacon/p2p/v1:go_default_library",
+        "//shared/params/spectest:go_default_library",
+        "//shared/testutil:go_default_library",
+        "@com_github_ghodss_yaml//:go_default_library",
+        "@com_github_prysmaticlabs_go_ssz//:go_default_library",
+        "@io_bazel_rules_go//go/tools/bazel:go_default_library",
+    ],
+)

beacon-chain/core/state/spectest/slot_processing_test.go

@@ -0,0 +1,68 @@
+package spectest
+
+import (
+	"context"
+	"io/ioutil"
+	"testing"
+
+	"github.com/bazelbuild/rules_go/go/tools/bazel"
+	"github.com/ghodss/yaml"
+	"github.com/prysmaticlabs/go-ssz"
+	"github.com/prysmaticlabs/prysm/beacon-chain/core/state"
+	pb "github.com/prysmaticlabs/prysm/proto/beacon/p2p/v1"
+	"github.com/prysmaticlabs/prysm/shared/params/spectest"
+	"github.com/prysmaticlabs/prysm/shared/testutil"
+)
+
+func TestSlotProcessingMainnet(t *testing.T) {
+	filepath, err := bazel.Runfile("/eth2_spec_tests/tests/sanity/slots/sanity_slots_mainnet.yaml")
+	if err != nil {
+		t.Fatal(err)
+	}
+	file, err := ioutil.ReadFile(filepath)
+	if err != nil {
+		t.Fatalf("Could not load file %v", err)
+	}
+
+	s := &SanitySlotsTest{}
+	if err := yaml.Unmarshal(file, s); err != nil {
+		t.Fatalf("Failed to Unmarshal: %v", err)
+	}
+
+	if err := spectest.SetConfig(s.Config); err != nil {
+		t.Fatal(err)
+	}
+
+	for _, tt := range s.TestCases {
+		t.Run(tt.Description, func(t *testing.T) {
+			preState := &pb.BeaconState{}
+			if err := testutil.ConvertToPb(tt.Pre, preState); err != nil {
+				t.Fatal(err)
+			}
+
+			var postState *pb.BeaconState
+
+			postState, err = state.ProcessSlots(context.Background(), preState, preState.Slot+tt.Slots)
+			if err != nil {
+				t.Fatal(err)
+			}
+
+			expectedPostState := &pb.BeaconState{}
+			if err := testutil.ConvertToPb(tt.Post, expectedPostState); err != nil {
+				t.Fatal(err)
+			}
+
+			expected, err := ssz.HashTreeRoot(expectedPostState)
+			if err != nil {
+				t.Fatal(err)
+			}
+			received, err := ssz.HashTreeRoot(postState)
+			if err != nil {
+				t.Fatal(err)
+			}
+			if expected != received {
+				t.Fatal("post state does not match")
+			}
+		})
+	}
+}

beacon-chain/core/state/transition.go

@@ -78,21 +78,37 @@ func ExecuteStateTransition(
 
 // ProcessSlot happens every slot and focuses on the slot counter and block roots record updates.
 // It happens regardless if there's an incoming block or not.
+// Spec pseudocode definition:
+//
+//  def process_slot(state: BeaconState) -> None:
+//    # Cache state root
+//    previous_state_root = hash_tree_root(state)
+//    state.state_roots[state.slot % SLOTS_PER_HISTORICAL_ROOT] = previous_state_root
+//
+//    # Cache latest block header state root
+//    if state.latest_block_header.state_root == ZERO_HASH:
+//        state.latest_block_header.state_root = previous_state_root
+//
+//    # Cache block root
+//    previous_block_root = signing_root(state.latest_block_header)
+//    state.block_roots[state.slot % SLOTS_PER_HISTORICAL_ROOT] = previous_block_root
 func ProcessSlot(ctx context.Context, state *pb.BeaconState) (*pb.BeaconState, error) {
 	ctx, span := trace.StartSpan(ctx, "beacon-chain.ChainService.state.ProcessSlot")
 	defer span.End()
 	prevStateRoot, err := ssz.HashTreeRoot(state)
 	if err != nil {
 		return nil, fmt.Errorf("could not tree hash prev state root: %v", err)
 	}
+
 	state.LatestStateRoots[state.Slot%params.BeaconConfig().SlotsPerHistoricalRoot] = prevStateRoot[:]
 	zeroHash := params.BeaconConfig().ZeroHash
 
 	// Cache latest block header state root.
 	if bytes.Equal(state.LatestBlockHeader.StateRoot, zeroHash[:]) {
 		state.LatestBlockHeader.StateRoot = prevStateRoot[:]
 	}
-	prevBlockRoot, err := ssz.HashTreeRoot(state.LatestBlockHeader)
+
+	prevBlockRoot, err := ssz.SigningRoot(state.LatestBlockHeader)
 	if err != nil {
 		return nil, fmt.Errorf("could not determine prev block root: %v", err)
 	}