Improvements to HTTP response handling #14673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasey
force-pushed
the
http-body-limits
branch
6 times, most recently
from
f714a6b to
3e933b9
Compare
kasey
force-pushed
the
http-body-limits
branch
from
3e933b9 to
11bc056
Compare
prestonvanloon
approved these changes
Nov 27, 2024
rkapka
approved these changes
Nov 27, 2024
saolyn
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a few places prysm makes http connections to other systems and reads all bytes before attempting to unmarshal the response. A best practice for this kind of client connection is to limit the number of bytes read to a reasonable upper bound.
What type of PR is this?
Other
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
Fixes #
Other notes for review
Acknowledgements