Add missed exit checks to consolidation processing #14603
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
force-pushed
the
consolidation-exit-checks
branch
from
53d5e21 to
386424c
Compare
james-prysm
previously approved these changes
Nov 1, 2024
| @@ -258,6 +265,18 @@ func ProcessConsolidationRequests(ctx context.Context, st state.BeaconState, req | |||
| continue | |||
| } | |||
|
|
|||
| if curEpoch < srcV.ActivationEpoch+params.BeaconConfig().ShardCommitteePeriod { | |||
There was a problem hiding this comment.
Overflow shouldn't be possible here since we verified that srcV is active, but we could defensively future proof here with an overflow check or math.SafeAdd.
What do you think?
prestonvanloon
previously approved these changes
Nov 2, 2024
james-prysm
previously approved these changes
Nov 4, 2024
|
gaz |
|
hmm tests failing? |
Blocked by new spec tests |
terencechain
force-pushed
the
consolidation-exit-checks
branch
from
7794a0a to
717e122
Compare
Revert params.SetupTestConfigCleanupWithLock(t)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a couple of checks that were missing from the consolidation request processing when handling a voluntary exit. These checks are:
reference: ethereum/consensus-specs#4000