HTTP endpoint for GetValidatorActiveSetChanges
#14264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
reviewed
Jul 25, 2024
beacon-chain/rpc/endpoints.go
Outdated
| template: "/prysm/v1/validators/active_set_changes", | ||
| name: namespace + ".GetValidatorActiveSetChanges", | ||
| middleware: []mux.MiddlewareFunc{ | ||
| middleware.ContentTypeHandler([]string{api.JsonMediaType}), |
There was a problem hiding this comment.
you don't need the content type handler for a get request
rkapka
reviewed
Aug 2, 2024
beacon-chain/rpc/endpoints.go
Outdated
| @@ -1087,5 +1088,14 @@ func (*Service) prysmValidatorEndpoints(coreService *core.Service) []endpoint { | |||
| handler: server.GetValidatorPerformance, | |||
| methods: []string{http.MethodPost}, | |||
| }, | |||
| { | |||
| template: "/prysm/v1/validators/active_set_changes", | |||
| name: namespace + ".GetValidatorActiveSetChanges", | |||
There was a problem hiding this comment.
One small nitpick: since the namespace is prysm.validator, there is no need to repeat the word Validator in every handler. Can you remove it from this one and all the other existing ones?
| httputil.WriteJson(w, response) | ||
| } | ||
|
|
||
| func byteArrayToString(byteArrays [][]byte) []string { |
There was a problem hiding this comment.
To be precise, this should be named byteSlice2dToStringSlice because:
- arrays are fixed-length
- we have a slice of slices
- the result is not a string, but a slice of strings
| return s | ||
| } | ||
|
|
||
| func uint64ArrayToString(indices []primitives.ValidatorIndex) []string { |
There was a problem hiding this comment.
This should technically be named uint64SliceToStringSlice
rkapka
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
Adding the HTTP endpoint for
GetValidatorActiveSetChanges.Same changes done here as to #14261
Which issues(s) does this PR fix?
N/A
Other notes for review