payload electra cloning #14239
Merged
payload electra cloning #14239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
commented
Jul 18, 2024
proto/engine/v1/execution_engine.go
Outdated
| } | ||
|
|
||
| // CopySlice copies the contents of a slice of pointers to a new slice. | ||
| func CopySlice[T any, C Cloneable[T]](original []C) []T { |
There was a problem hiding this comment.
maybe I should move this to some util package?
There was a problem hiding this comment.
IMO should probably be unexported, as it's a trivial func and copying it around seems cleaner to me than making a util that all the proto packages need to import.
james-prysm
added
Cleanup
kasey
previously approved these changes
Jul 19, 2024
|
|
||
| type Cloneable[T any] interface { | ||
| Copy() T | ||
| } |
There was a problem hiding this comment.
I'm going to approve so you can move on, but my nitpick is that we should name the interface after the method (Cloneable does not follow intuitively from Copy - the reflexive naming here should be something more like Copyer). If you want to address that now I'd appreciate it and give a fast follow-up approval, or you can do it in the follow-up PRs. Also, should the interface be exported?
kasey
previously approved these changes
Jul 19, 2024
kasey
previously approved these changes
Jul 19, 2024
kasey
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
Attempting to make cloners more robust and more generic.
This PR only addresses for payload electra but other types can be taken cared of in subsequent PRs
Which issues(s) does this PR fix?
Fixes #
Other notes for review