Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing pieces of Electra #14227

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Add missing pieces of Electra #14227

merged 2 commits into from
Jul 16, 2024

Conversation

rkapka
Copy link
Contributor

@rkapka rkapka commented Jul 16, 2024 •
edited
Loading

What type of PR is this?

Other

What does this PR do? Why is it needed?

  • Set committee index to 0 for Electra inside GetAttestationData
  • Use PayloadAttributesV3 for Electra inside getPayloadAttribute
  • Save AttestationElectra and AttesterSlashingElectra as SSZ objects
  • Use IndexedAtt interface in validator database code

@rkapka rkapka requested a review from a team as a code owner July 16, 2024 17:20
@rkapka rkapka force-pushed the electra-missing-things branch from 263eac7 to 6960a94 Compare July 16, 2024 17:36
@rkapka rkapka enabled auto-merge July 16, 2024 18:04
@rkapka rkapka added Ready For Review A pull request ready for code review Electra electra hardfork labels Jul 16, 2024
james-prysm
james-prysm approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@james-prysm james-prysm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rkapka rkapka added this pull request to the merge queue Jul 16, 2024
Merged via the queue into develop with commit 637cbc8 Jul 16, 2024
16 of 17 checks passed
@rkapka rkapka deleted the electra-missing-things branch July 16, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-prysm james-prysm james-prysm approved these changes

@kasey kasey Awaiting requested review from kasey kasey is a code owner automatically assigned from prysmaticlabs/core-team

@terencechain terencechain Awaiting requested review from terencechain terencechain is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
Electra electra hardfork Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkapka @james-prysm