Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electra: process_consolidation_requests in state transition #14219

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

prestonvanloon
Copy link
Member

What type of PR is this?

Other

What does this PR do? Why is it needed?

Resolves a TODO

Which issues(s) does this PR fix?

This method is primarily tested through spectests. A PR to unskip the relevant spectests is
forthcoming this week.

Other notes for review

@prestonvanloon prestonvanloon requested a review from a team as a code owner July 15, 2024 15:50
@prestonvanloon prestonvanloon added the Electra electra hardfork label Jul 15, 2024
@@ -93,6 +94,8 @@ func ProcessOperations(
return nil, errors.Wrap(err, "could not process deposit receipts")
}

// TODO: Process consolidations from execution header.
if err := ProcessConsolidationRequests(ctx, st, exe.ConsolidationRequests()); err != nil {
return nil, fmt.Errorf("could not process consolidation requests: %w", err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could also do errors.Wrap like above but either is ok

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be moving away from errors.Wrap

@prestonvanloon prestonvanloon added this pull request to the merge queue Jul 15, 2024
Merged via the queue into develop with commit 422438f Jul 15, 2024
17 checks passed
@prestonvanloon prestonvanloon deleted the electra-process_consolidation_requests branch July 15, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Electra electra hardfork
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants