Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electra: Handle AttestationElectra in forkchoice spectest #14180

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

prestonvanloon
Copy link
Member

What type of PR is this?

Other

What does this PR do? Why is it needed?

This still fails, but no longer failing for ssz unmarshalling errors.
The test is currently skipped, but unskipping shows the following errors for minimal spectest

--- FAIL: TestMinimal_Electra_Forkchoice (26.47s)                                                                                                                         
    --- FAIL: TestMinimal_Electra_Forkchoice/voting_source_within_two_epoch (0.60s)                                                                                       
        assertions.go:144: builder.go:139 Unexpected error: could not create attestation ID: 2 committee bits are set instead of 1                                        
    --- FAIL: TestMinimal_Electra_Forkchoice/justification_withholding_reverse_order (0.39s)                                                                              
        assertions.go:144: builder.go:139 Unexpected error: could not create attestation ID: 2 committee bits are set instead of 1                                        
    --- FAIL: TestMinimal_Electra_Forkchoice/simple_blob_data (0.08s)                                                                                                     
        runner.go:386: SidecarInclusionProven error: sidecar inclusion proof verification failed: blob failed verification                                                
        runner.go:431: sidecar inclusion proof verification failed: blob failed verification - RequireSidecarInclusionProven                                              
    --- FAIL: TestMinimal_Electra_Forkchoice/withholding_attack_unviable_honest_chain (0.36s)                                                                             
        assertions.go:144: builder.go:139 Unexpected error: could not create attestation ID: 2 committee bits are set instead of 1                                        
FAIL

Which issues(s) does this PR fix?

Other notes for review

@prestonvanloon prestonvanloon requested a review from a team as a code owner July 3, 2024 14:22
@prestonvanloon prestonvanloon requested review from saolyn, potuz and nisdas July 3, 2024 14:22
@prestonvanloon prestonvanloon added the Electra electra hardfork label Jul 3, 2024
@prestonvanloon prestonvanloon requested a review from rkapka July 3, 2024 14:22
@prestonvanloon prestonvanloon enabled auto-merge July 3, 2024 14:23
@prestonvanloon prestonvanloon force-pushed the electra-att-forkchoice-fix branch from f732ee4 to 7e51b5c Compare July 11, 2024 21:09
@prestonvanloon prestonvanloon force-pushed the electra-att-forkchoice-fix branch from 7e51b5c to e0c7c5e Compare July 12, 2024 16:40
@prestonvanloon prestonvanloon added this pull request to the merge queue Jul 12, 2024
Merged via the queue into develop with commit 3eacc37 Jul 12, 2024
16 of 17 checks passed
@prestonvanloon prestonvanloon deleted the electra-att-forkchoice-fix branch July 12, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Electra electra hardfork
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants