Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Backoff When Searching For Viable Peers #14148

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Jun 26, 2024

What type of PR is this?

Bug Fix

What does this PR do? Why is it needed?

In #14137, we introduced a few things to allow for nodes running in more restrictive operating systems to be able to maintain their peer count. Unfortunately these changes have lead to poorer attestation and sync committee performance, this PR reverts one of those changes which would slow down peer search if we encountered too many non-viable peers.

Which issues(s) does this PR fix?

N.A

Other notes for review

@nisdas nisdas added Ready For Review A pull request ready for code review Networking P2P related items labels Jun 26, 2024
@nisdas nisdas requested a review from a team as a code owner June 26, 2024 06:06
@nisdas nisdas added this pull request to the merge queue Jun 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 27, 2024
@nisdas nisdas added this pull request to the merge queue Jun 27, 2024
Merged via the queue into develop with commit 4becd7b Jun 27, 2024
17 checks passed
@nisdas nisdas deleted the revertSearchBackoff branch June 27, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Networking P2P related items Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants