Cleanup: making process deposit more spec readable and fork specific #14139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic, breaking out components of pr 13944
saolyn
approved these changes
Jun 24, 2024
| ) | ||
|
|
||
| // ProcessPreGenesisDeposits processes a deposit for the beacon state before chainstart. |
There was a problem hiding this comment.
Why are these in altair? I think these additions are not part of altair hard fork right
There was a problem hiding this comment.
the alternative would be to break out process deposits into yet another for phase 0. I considered this but just decided to have the two ( altair and electra). if you think I should still break this out I can.
the issue with leaving it in the blocks package is the circular dependency, processPreGenesisDeposits calls process deposits which needs to specify a fork for process deposits, in this case it only makes sense to use the current version of process deposits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
Currently, the
ProcessDepositfunction lives in a shared fork repo in theblockspackage. To prepare for changes in 6110 I have broken the functions to match more closely with the consensus specs defined in https://github.com/ethereum/consensus-specs. As part of this PR I've moved the deposit functions from the blocks package to the altair package which will allow easier updating in future hard forks.breaking out pr #13944
Which issues(s) does this PR fix?
Fixes #
Other notes for review