refactor: use go ticker instead of timer #14134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @james-prysm wondering if you can take a look at this one |
james-prysm
reviewed
Jun 24, 2024
| @@ -100,14 +100,13 @@ func (vs *Server) WaitForActivation(req *ethpb.ValidatorActivationRequest, strea | |||
| } | |||
|
|
|||
| waitTime := time.Duration(params.BeaconConfig().SecondsPerSlot) * time.Second | |||
| timer := time.NewTimer(waitTime) | |||
| defer timer.Stop() | |||
| ticker := time.NewTicker(waitTime) | |||
There was a problem hiding this comment.
I don't think we need to use a ticker here , instead using the New Timer because we only have a 1 time action. Wait for Activation only triggers if there are 0 active keys while accounts are updated. the action no longer needs to run afterwards
There was a problem hiding this comment.
The loop finishes when activeValidatorExists is true, and using NewTicker will remove the need for the manual timer.Reset(waitTime) call
There was a problem hiding this comment.
ok that's fair, I think you're right on this and I was mistaken
There was a problem hiding this comment.
Thanks for this I'll go ahead and approve
james-prysm
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
Fixes #
Other notes for review