eip-7251: process_registry_updates #14005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
reviewed
May 16, 2024
james-prysm
reviewed
May 16, 2024
prestonvanloon
force-pushed
the
eip-7251-registry_updates
branch
from
74e3000
to
09c8c9a
Compare
|
Working on fixing this up. Just needs more unit tests (spectests are passing) |
prestonvanloon
force-pushed
the
eip-7251-registry_updates
branch
6 times, most recently
from
c4eda0b
to
8fa05b7
Compare
james-prysm
reviewed
Jun 18, 2024
saolyn
reviewed
Jun 18, 2024
saolyn
reviewed
Jun 18, 2024
saolyn
previously approved these changes
Jun 18, 2024
terencechain
requested changes
Jun 18, 2024
| currentEpoch := time.CurrentEpoch(state) | ||
| ejectionBal := params.BeaconConfig().EjectionBalance | ||
| activationEpoch := helpers.ActivationExitEpoch(currentEpoch) | ||
| vals := state.Validators() |
There was a problem hiding this comment.
state.Validators() copies the entire validator set and this is very expensive given the current validator set size.
Have you thought about using ValidatorsReadOnly or ReadFromEveryValidator
There was a problem hiding this comment.
Good point. I'll do something about this
There was a problem hiding this comment.
This is done now. Using the same design as #14130
|
Design in #14130 was approved. I'll update this PR today to adopt that design. |
prestonvanloon
force-pushed
the
eip-7251-registry_updates
branch
from
8a1b0e2
to
0a1500b
Compare
terencechain
previously approved these changes
Jun 28, 2024
prestonvanloon
force-pushed
the
eip-7251-registry_updates
branch
from
0a1500b
to
59cbc83
Compare
terencechain
previously approved these changes
Jun 28, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Co-authored-by: Sammy Rosso <15244892+saolyn@users.noreply.github.com>
prestonvanloon
force-pushed
the
eip-7251-registry_updates
branch
from
59cbc83
to
69873db
Compare
potuz
approved these changes
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Required for Electra.
Extracted from #13903.
Which issues(s) does this PR fix?
Tracking @ #13849
Other notes for review