Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore []*ethpb.SignedConsolidation if it's nil #13990

Merged
merged 1 commit into from
May 12, 2024
Merged

Conversation

terencechain
Copy link
Member

In Go, if you range over a nil slice, it behaves like an empty slice. The loop body will not execute because there are no elements to iterate over. This means that the program won't panic or throw an error.
For a beacon block, if the block does not contain any consolidation, the field is nil by default. This is similar to attestation and other deposit objects. We should not cause the state transition function to fail, as that would result in a consensus failure. Another approach to altering this behavior involves how the block is initialized; if the object is nil in p2p, we initialize an empty list instead of nil, but this warrants a more significant change.

@terencechain terencechain requested a review from a team as a code owner May 12, 2024 14:22
@terencechain terencechain requested review from nalepae, saolyn and potuz and removed request for a team May 12, 2024 14:22
Copy link
Member

@prestonvanloon prestonvanloon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I'll make sure this lands in #13983

@prestonvanloon prestonvanloon merged commit 7c7d1df into eip-7251 May 12, 2024
12 of 16 checks passed
@prestonvanloon prestonvanloon deleted the fix-nil branch May 12, 2024 15:01
prestonvanloon pushed a commit that referenced this pull request May 12, 2024
prestonvanloon pushed a commit that referenced this pull request May 12, 2024
prestonvanloon pushed a commit that referenced this pull request May 13, 2024
prestonvanloon pushed a commit that referenced this pull request May 13, 2024
prestonvanloon pushed a commit that referenced this pull request May 13, 2024
prestonvanloon pushed a commit that referenced this pull request May 13, 2024
prestonvanloon pushed a commit that referenced this pull request May 13, 2024
prestonvanloon pushed a commit that referenced this pull request May 13, 2024
prestonvanloon pushed a commit that referenced this pull request May 13, 2024
prestonvanloon pushed a commit that referenced this pull request May 14, 2024
prestonvanloon pushed a commit that referenced this pull request May 14, 2024
prestonvanloon pushed a commit that referenced this pull request May 14, 2024
prestonvanloon pushed a commit that referenced this pull request May 14, 2024
prestonvanloon pushed a commit that referenced this pull request May 14, 2024
prestonvanloon pushed a commit that referenced this pull request May 14, 2024
prestonvanloon pushed a commit that referenced this pull request May 14, 2024
prestonvanloon pushed a commit that referenced this pull request May 14, 2024
prestonvanloon pushed a commit that referenced this pull request May 14, 2024
prestonvanloon pushed a commit that referenced this pull request May 14, 2024
prestonvanloon pushed a commit that referenced this pull request May 15, 2024
prestonvanloon pushed a commit that referenced this pull request May 15, 2024
prestonvanloon pushed a commit that referenced this pull request May 15, 2024
prestonvanloon pushed a commit that referenced this pull request May 16, 2024
prestonvanloon pushed a commit that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants