-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore []*ethpb.SignedConsolidation
if it's nil
#13990
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
requested review from
nalepae,
saolyn and
potuz
and removed request for
a team
May 12, 2024 14:22
prestonvanloon
approved these changes
May 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. I'll make sure this lands in #13983
prestonvanloon
pushed a commit
that referenced
this pull request
May 12, 2024
prestonvanloon
pushed a commit
that referenced
this pull request
May 12, 2024
prestonvanloon
pushed a commit
that referenced
this pull request
May 13, 2024
prestonvanloon
pushed a commit
that referenced
this pull request
May 13, 2024
prestonvanloon
pushed a commit
that referenced
this pull request
May 13, 2024
prestonvanloon
pushed a commit
that referenced
this pull request
May 13, 2024
prestonvanloon
pushed a commit
that referenced
this pull request
May 13, 2024
prestonvanloon
pushed a commit
that referenced
this pull request
May 13, 2024
prestonvanloon
pushed a commit
that referenced
this pull request
May 13, 2024
prestonvanloon
pushed a commit
that referenced
this pull request
May 14, 2024
prestonvanloon
pushed a commit
that referenced
this pull request
May 14, 2024
prestonvanloon
pushed a commit
that referenced
this pull request
May 14, 2024
prestonvanloon
pushed a commit
that referenced
this pull request
May 14, 2024
prestonvanloon
pushed a commit
that referenced
this pull request
May 14, 2024
prestonvanloon
pushed a commit
that referenced
this pull request
May 14, 2024
prestonvanloon
pushed a commit
that referenced
this pull request
May 14, 2024
prestonvanloon
pushed a commit
that referenced
this pull request
May 14, 2024
prestonvanloon
pushed a commit
that referenced
this pull request
May 14, 2024
prestonvanloon
pushed a commit
that referenced
this pull request
May 14, 2024
prestonvanloon
pushed a commit
that referenced
this pull request
May 15, 2024
prestonvanloon
pushed a commit
that referenced
this pull request
May 15, 2024
prestonvanloon
pushed a commit
that referenced
this pull request
May 15, 2024
prestonvanloon
pushed a commit
that referenced
this pull request
May 16, 2024
prestonvanloon
pushed a commit
that referenced
this pull request
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Go, if you range over a nil slice, it behaves like an empty slice. The loop body will not execute because there are no elements to iterate over. This means that the program won't panic or throw an error.
For a beacon block, if the block does not contain any consolidation, the field is nil by default. This is similar to attestation and other deposit objects. We should not cause the state transition function to fail, as that would result in a consensus failure. Another approach to altering this behavior involves how the block is initialized; if the object is nil in p2p, we initialize an empty list instead of nil, but this warrants a more significant change.