Always Set Inprogress Boolean In Cache #13750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvanloon
approved these changes
Mar 15, 2024
|
Shouldn't |
|
I don't think there can be a race on reading these, as we first come out from round robin before starting to sync and it's only changed under locks I think. |
|
I'd confirm that it is only changed under locks. I didn't see any relevant ones but I could've missed one. I'm also not sure how this issue would be hit if the relevant sections of code were under locks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug Fix
What does this PR do? Why is it needed?
For our skip slot cache, we always set the in-progress boolean for a particular root regardless if it is enabled or disabled. This helps avoid wierd edge cases where the skip slot cache is disabled and then enabled which might lead to wierd deadlocks.
Which issues(s) does this PR fix?
Other notes for review