Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Unrealized Justification Balances In Spectests #13710

Merged
merged 8 commits into from
Mar 8, 2024

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Mar 8, 2024

What type of PR is this?

Testing Improvement

What does this PR do? Why is it needed?

  • Adds in spec test checks for unrealized justification balances.
  • Handles possible overflow of activation epoch.

Which issues(s) does this PR fix?

N.A

Other notes for review

@nisdas nisdas added the Ready For Review A pull request ready for code review label Mar 8, 2024
@nisdas nisdas marked this pull request as ready for review March 8, 2024 13:23
@nisdas nisdas requested a review from a team as a code owner March 8, 2024 13:23
@nisdas nisdas requested review from kasey, potuz and james-prysm March 8, 2024 13:23
potuz
potuz previously approved these changes Mar 8, 2024
prestonvanloon
prestonvanloon previously approved these changes Mar 8, 2024
@prestonvanloon prestonvanloon enabled auto-merge March 8, 2024 13:37
@nisdas nisdas dismissed stale reviews from prestonvanloon and potuz via b9e151e March 8, 2024 13:46
@prestonvanloon prestonvanloon added this pull request to the merge queue Mar 8, 2024
Merged via the queue into develop with commit 2616de1 Mar 8, 2024
16 of 17 checks passed
@prestonvanloon prestonvanloon deleted the unrealizedJustificationTests branch March 8, 2024 14:56
prestonvanloon pushed a commit that referenced this pull request Mar 8, 2024
* add them

* Ensure activation epoch does not overflow

* add them all in

* better check for overflow

* fix tests

* fix tests

---------

Co-authored-by: Potuz <potuz@prysmaticlabs.com>
(cherry picked from commit 2616de1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants