Use Max Request Limit in Initial Sync #13641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
added
Ready For Review
Sync
nalepae
reviewed
Feb 21, 2024
| } | ||
| castedMaxLimit, err := math.Int(maxLimit) | ||
| if err != nil { | ||
| // Should be impossible to hit this case. |
There was a problem hiding this comment.
Maybe add an error log if such a case happens?
nalepae
approved these changes
Feb 21, 2024
kasey
reviewed
Feb 21, 2024
| func maxBatchLimit() int { | ||
| currLimit := flags.Get().BlockBatchLimit | ||
| maxLimit := params.BeaconConfig().MaxRequestBlocks | ||
| if params.DenebEnabled() { |
There was a problem hiding this comment.
The limit is a function of which p2p topic we are subscribed to. I think we need to base this on current slot.
There was a problem hiding this comment.
Take a look at
prysm/config/params/network_config.go
Line 47 in 5a66807
There was a problem hiding this comment.
Resolved in side discussion - this is kind of a hack but the effect is only lowering the batch size. Larger batch sizes probably are not that helpful anyway given how we parallelize requests.
kasey
approved these changes
Feb 21, 2024
prestonvanloon
pushed a commit
that referenced
this pull request
Mar 1, 2024
* use max limit * manu's review (cherry picked from commit e6a6365)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Deneb Improvement
What does this PR do? Why is it needed?
In the event a user provides a larger than expected batch limit, we will lower it to be inline with network limits. This is to prevent users from being silently banned by all peers for requesting too large of a batch.
Which issues(s) does this PR fix?
N.A
Other notes for review
#13499 #13502