replace receive slot with event stream #13563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
commented
Feb 1, 2024
api/client/event/eventStream.go
Outdated
| var eventType, data string // Variables to store event type and data | ||
|
|
||
| // Iterate over lines of the event stream | ||
| for scanner.Scan() { |
There was a problem hiding this comment.
is a span enough...
james-prysm
changed the title
james-prysm
commented
Mar 6, 2024
| @@ -45,6 +49,29 @@ type Server struct { | |||
| BeaconMonitoringPort int | |||
| } | |||
|
|
|||
| // GetHealth checks the health of the node | |||
| func (ns *Server) GetHealth(ctx context.Context, request *ethpb.HealthRequest) (*empty.Empty, error) { | |||
| _, span := trace.StartSpan(ctx, "node.GetHealth") | |||
There was a problem hiding this comment.
Suggested change
| _, span := trace.StartSpan(ctx, "node.GetHealth") | |
| ctx, span := trace.StartSpan(ctx, "node.GetHealth") |
If you don't overwrite the context, then the span details are not carried forward to other requests.
There was a problem hiding this comment.
Also, should you set some deadline, perhaps the server should respond within 10 seconds or give up waiting?
There was a problem hiding this comment.
added a deadline in the function if that's what you're suggesting, i don't think other similar functions have deadlines though, it might default to something for grpc. more tests were added though.
Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com>
prestonvanloon
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
/eth/v1/events
Removes the receive slot function and replaces it with an event stream.
this is a big change