Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the algorithm of updateFinalizedBlockRoots #13486

Merged
merged 13 commits into from
Mar 21, 2024
Merged

Modify the algorithm of updateFinalizedBlockRoots #13486

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
7e2520f
rename error var
rkapka Jan 15, 2024
6b36e66
new algo
rkapka Jan 18, 2024
77b311f
replay_test
rkapka Jan 18, 2024
38579c4
add comment
rkapka Jan 18, 2024
52a38b8
Merge branch '__develop' into finalized-blocks-audit
rkapka Feb 26, 2024
f96c5a3
review
rkapka Feb 28, 2024
34755c5
fill out parent root
rkapka Feb 28, 2024
8d4fcd7
Merge branch '__develop' into finalized-blocks-audit
rkapka Feb 28, 2024
64cde45
handle edge cases
rkapka Mar 4, 2024
b119648
Merge branch '__develop' into finalized-blocks-audit
rkapka Mar 4, 2024
b4d4e6d
merge with develop
rkapka Mar 18, 2024
dabf5b8
review
rkapka Mar 20, 2024
f4880c6
Merge branch 'develop' into finalized-blocks-audit
rkapka Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions beacon-chain/db/kv/finalized_block_roots.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,18 @@ func (s *Store) updateFinalizedBlockRoots(ctx context.Context, tx *bolt.Tx, chec
if i == len(finalized)-1 {
// We don't know the finalized child of the new finalized checkpoint.
// It will be filled out in the next function call.
container = &ethpb.FinalizedBlockRootContainer{}
container = &ethpb.FinalizedBlockRootContainer{
ParentRoot: finalized[i-1],
}
} else if i == 0 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be better to use a switch statement ? If not handling i in a progressive order is reads better

if i == 0 {
// do something
else if i == len(finalized) -1 {
// do something
} else {
// ...
}

container = &ethpb.FinalizedBlockRootContainer{
ParentRoot: previousFinalizedCheckpoint.Root,
ChildRoot: finalized[i+1],
}
} else {
container = &ethpb.FinalizedBlockRootContainer{
ChildRoot: finalized[i+1],
ParentRoot: finalized[i-1],
ChildRoot: finalized[i+1],
}
}
enc, err := encode(ctx, container)
Expand Down