Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libp2p/go-libp2p-asn-util to v0.4.1 #13370

Merged
merged 3 commits into from
Jan 2, 2024
Merged

Conversation

prestonvanloon
Copy link
Member

What type of PR is this?

Other

What does this PR do? Why is it needed?

Updates go-libp2p-asn-util to v0.4.1. This includes libp2p/go-libp2p-asn-util#33 which has a
significant build time improvement for Prysm.

=== PHASE SUMMARY INFORMATION ===

Total launch phase time                              0.641 s    0.58%
Total init phase time                                1.740 s    1.59%
Total target pattern evaluation phase time           0.035 s    0.03%
Total interleaved loading-and-analysis phase time   25.169 s   22.92%
Total preparation phase time                         0.014 s    0.01%
Total execution phase time                          82.183 s   74.85%
Total finish phase time                              0.013 s    0.01%
---------------------------------------------------------------------
Total run time                                     109.798 s  100.00%

Critical path (59.991 s):
       Time Percentage   Description
   14.429 s   24.05%   action 'GoToolchainBinaryBuild external/go_sdk/builder [for tool]'
    0.44 ms    0.00%   action 'Creating symlink bazel-out/k8-opt-exec-2B5CBBC6-ST-933a6b66542f/bin/external/go_sdk/builder_reset/builder [for tool]'
   22.304 s   37.18%   action 'GoStdlib external/io_bazel_rules_go/stdlib_/pkg [for tool]'
     122 ms    0.20%   action 'GoCompilePkg external/org_golang_x_tools/internal/typeparams/typeparams.a [for tool]'
     150 ms    0.25%   action 'GoCompilePkg external/org_golang_x_tools/go/ast/astutil/astutil.a [for tool]'
     121 ms    0.20%   action 'GoCompilePkg external/org_golang_x_tools/go/types/typeutil/typeutil.a [for tool]'
     199 ms    0.33%   action 'GoCompilePkg external/co_honnef_go_tools/go/types/typeutil/typeutil.a [for tool]'
     962 ms    1.60%   action 'GoCompilePkg external/co_honnef_go_tools/go/ir/ir.a [for tool]'
     129 ms    0.22%   action 'GoCompilePkg external/co_honnef_go_tools/go/ir/irutil/irutil.a [for tool]'
     106 ms    0.18%   action 'GoCompilePkg external/co_honnef_go_tools/analysis/facts/purity/purity.a [for tool]'
    95.4 ms    0.16%   action 'GoCompilePkg external/co_honnef_go_tools/analysis/code/code.a [for tool]'
    66.1 ms    0.11%   action 'GoCompilePkg external/co_honnef_go_tools/analysis/report/report.a [for tool]'
    83.1 ms    0.14%   action 'GoCompilePkg external/co_honnef_go_tools/analysis/callcheck/callcheck.a [for tool]'
     247 ms    0.41%   action 'GoCompilePkg external/co_honnef_go_tools/staticcheck/sa1027/sa1027.a [for tool]'
     211 ms    0.35%   action 'GoCompilePkg nogo_actual~nogo.a [for tool]'
    1.185 s    1.97%   action 'GoLink nogo_actual_/nogo_actual [for tool]'
    9.733 s   16.22%   action 'GoCompilePkg external/com_github_ethereum_go_ethereum/crypto/secp256k1/secp256k1.a'
     123 ms    0.21%   action 'GoCompilePkg external/com_github_ethereum_go_ethereum/crypto/crypto.a'
     262 ms    0.44%   action 'GoCompilePkg external/com_github_ethereum_go_ethereum/core/types/types.a'
     333 ms    0.55%   action 'GoCompilePkg proto/engine/v1/go_default_library.a'
    1.911 s    3.19%   action 'GoCompilePkg proto/prysm/v1alpha1/go_default_library.a'
     213 ms    0.35%   action 'GoCompilePkg proto/prysm/v1alpha1/validator-client/go_default_library.a'
     122 ms    0.20%   action 'GoCompilePkg consensus-types/interfaces/go_default_library.a'
     156 ms    0.26%   action 'GoCompilePkg beacon-chain/state/go_default_library.a'
     244 ms    0.41%   action 'GoCompilePkg beacon-chain/cache/go_default_library.a'
     241 ms    0.40%   action 'GoCompilePkg beacon-chain/core/helpers/go_default_library.a'
     134 ms    0.22%   action 'GoCompilePkg beacon-chain/core/validators/go_default_library.a'
     228 ms    0.38%   action 'GoCompilePkg beacon-chain/core/blocks/go_default_library.a'
     283 ms    0.47%   action 'GoCompilePkg beacon-chain/db/kv/go_default_library.a'``
     120 ms    0.20%   action 'GoCompilePkg beacon-chain/db/go_default_library.a'
     121 ms    0.20%   action 'GoCompilePkg beacon-chain/sync/backfill/go_default_library.a'
     169 ms    0.28%   action 'GoCompilePkg beacon-chain/state/stategen/go_default_library.a'
     238 ms    0.40%   action 'GoCompilePkg beacon-chain/execution/go_default_library.a'
     302 ms    0.50%   action 'GoCompilePkg beacon-chain/blockchain/go_default_library.a'
     403 ms    0.67%   action 'GoCompilePkg beacon-chain/sync/go_default_library.a'
     180 ms    0.30%   action 'GoCompilePkg beacon-chain/rpc/core/go_default_library.a'
     143 ms    0.24%   action 'GoCompilePkg beacon-chain/rpc/lookup/go_default_library.a'
     309 ms    0.51%   action 'GoCompilePkg beacon-chain/rpc/eth/shared/go_default_library.a'
     339 ms    0.57%   action 'GoCompilePkg api/client/builder/go_default_library.a'
     144 ms    0.24%   action 'GoCompilePkg beacon-chain/builder/go_default_library.a'
     281 ms    0.47%   action 'GoCompilePkg beacon-chain/rpc/prysm/v1alpha1/validator/go_default_library.a'
     214 ms    0.36%   action 'GoCompilePkg beacon-chain/rpc/go_default_library.a'
     255 ms    0.43%   action 'GoCompilePkg beacon-chain/node/go_default_library.a'
     150 ms    0.25%   action 'GoCompilePkg cmd/beacon-chain/sync/checkpoint/go_default_library.a'
     152 ms    0.25%   action 'GoCompilePkg cmd/beacon-chain/sync/genesis/go_default_library.a'
     151 ms    0.25%   action 'GoCompilePkg cmd/beacon-chain/beacon-chain.a'
    1.927 s    3.21%   action 'GoLink cmd/beacon-chain/beacon-chain_/beacon-chain'
    0.05 ms    0.00%   runfiles for //cmd/beacon-chain beacon-chain

Which issues(s) does this PR fix?

Replacement PR for #13306

Other notes for review

See #13306 (comment)

@prestonvanloon prestonvanloon requested a review from a team as a code owner December 20, 2023 16:03
@prestonvanloon prestonvanloon added the dependencies Pull requests that update a dependency file label Dec 20, 2023
@prestonvanloon
Copy link
Member Author

This PR will likely (definitely) conflict with #13304. So let's merge that one first and handle conflicts in this PR. @nisdas

@Jorropo
Copy link

Jorropo commented Dec 23, 2023

10% build-time improvements from this ? 🎉
I'm impressed myself.

terencechain
terencechain previously approved these changes Jan 1, 2024
Copy link
Member

@terencechain terencechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this can be merged 🚀

@nisdas nisdas enabled auto-merge January 2, 2024 06:54
@nisdas nisdas added this pull request to the merge queue Jan 2, 2024
Merged via the queue into develop with commit 0956e3a Jan 2, 2024
17 checks passed
@nisdas nisdas deleted the update-go-libp2p-asn-util branch January 2, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants