Add spec test for v1.4.0-alpha.0 #12460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saolyn
reviewed
May 25, 2023
WORKSPACE
Outdated
| @@ -221,7 +221,7 @@ filegroup( | |||
| visibility = ["//visibility:public"], | |||
| ) | |||
| """, | |||
| sha256 = "1c806e04ac5e3779032c06a6009350b3836b6809bb23812993d6ececd7047cf5", | |||
| #sha256 = "1c806e04ac5e3779032c06a6009350b3836b6809bb23812993d6ececd7047cf5", | |||
There was a problem hiding this comment.
Why is this one commented out rather than being replaced like the others?
There was a problem hiding this comment.
My fault. I forgot to update it. 6073026
saolyn
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add spec test for
v1.4.0-alpha.0The placeholder configs are coming from ethereum/consensus-specs#3312 which we haven't looked much into