Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forkchoice changes #12126

Merged
merged 12 commits into from
Mar 16, 2023
Merged

forkchoice changes #12126

merged 12 commits into from
Mar 16, 2023

Conversation

potuz
Copy link
Contributor

@potuz potuz commented Mar 14, 2023

Implement ethereum/consensus-specs#3290, see there for description

@potuz potuz requested a review from a team as a code owner March 14, 2023 16:02
@potuz potuz added the Blocked Blocked by research or external factors label Mar 14, 2023
@potuz potuz added the Cleanup Code health! label Mar 14, 2023
@prestonvanloon
Copy link
Member

I ran these changes with the test vectors provided in the upstream PR, but at least one target fails.

bazel test //testing/spectest/minimal/phase0/forkchoice:go_default_test

Attached test.log

@potuz potuz merged commit 99997fa into develop Mar 16, 2023
@delete-merged-branch delete-merged-branch bot deleted the forkchoice-update branch March 16, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terencechain terencechain terencechain left review comments

@prestonvanloon prestonvanloon prestonvanloon approved these changes

@kasey kasey Awaiting requested review from kasey kasey is a code owner automatically assigned from prysmaticlabs/core-team

@rauljordan rauljordan Awaiting requested review from rauljordan rauljordan is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
Blocked Blocked by research or external factors Cleanup Code health!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@potuz @prestonvanloon @terencechain