Sign BLS_TO_EXECUTION_CHANGES with GENESIS_FORK_VERSION #11870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potuz
added
Blocked
| @@ -236,7 +236,7 @@ filegroup( | |||
| visibility = ["//visibility:public"], | |||
| ) | |||
| """, | |||
| sha256 = "78400c82f1978147feeab54e3deccb29c024efa13d6753adc8687ae008bae246", | |||
| sha256 = "bb06d30ca533dc97d45f2367916ba9ff1b5af52f08a9d8c33bb7b1a61254094e", | |||
| url = "https://github.com/ethereum/consensus-spec-tests/releases/download/%s/mainnet.tar.gz" % consensus_spec_version, | |||
| ) | |||
|
|
|||
There was a problem hiding this comment.
can you update sha256 at L254 for consensus_spec?
terencechain
previously approved these changes
Jan 13, 2023
terencechain
previously approved these changes
Jan 13, 2023
nisdas
approved these changes
Jan 16, 2023
delete-merged-branch
bot
deleted the
sign-bls-changes-with-genesis-fork
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
GENESIS_FORK_VERSIONwhen validatingBLS_TO_EXECUTION_CHANGESsignatures.Implements ethereum/consensus-specs#3206 and it should merge
when that PR merges.Update: it updates spectest vectors to 1.3.0-rc-1