Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change withdrawal amount unmarshal to uint64 (gwei) #11866

Merged
merged 7 commits into from
Jan 16, 2023

Conversation

terencechain
Copy link
Member

This PR implements ethereum/execution-apis#354. It updates the unmarshal for Engine API with the change to use the same units (Gwei) for the amount in each withdrawal as the consensus layer

@terencechain terencechain requested a review from a team as a code owner January 12, 2023 19:09
@terencechain terencechain self-assigned this Jan 12, 2023
@terencechain terencechain added Ready For Review Blocked Blocked by research or external factors labels Jan 12, 2023
@terencechain
Copy link
Member Author

Do not merge this until #354 is merged

@rkapka
Copy link
Contributor

rkapka commented Jan 13, 2023

Do not merge this until #354 is merged

#354 is some very old Prysm PR

@terencechain terencechain removed the Blocked Blocked by research or external factors label Jan 16, 2023
@prylabs-bulldozer prylabs-bulldozer bot merged commit 5480d60 into develop Jan 16, 2023
@delete-merged-branch delete-merged-branch bot deleted the withdrawal-unmarshal-amount branch January 16, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants