Add feature flag to treat all blocks as optimistic at startup #11303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
config/features/config.go
Outdated
| @@ -66,6 +66,7 @@ type Flags struct { | |||
| DisableForkchoiceDoublyLinkedTree bool // DisableForkChoiceDoublyLinkedTree specifies whether fork choice store will use a doubly linked tree. | |||
| EnableBatchGossipAggregation bool // EnableBatchGossipAggregation specifies whether to further aggregate our gossip batches before verifying them. | |||
| EnableOnlyBlindedBeaconBlocks bool // EnableOnlyBlindedBeaconBlocks enables only storing blinded beacon blocks in the DB post-Bellatrix fork. | |||
| EnableEverytingOptimistic bool // EnableEverythingOptimistic treats every block as optimistic at startup. | |||
There was a problem hiding this comment.
How about EnableStartupOptimistic ?
config/features/flags.go
Outdated
| @@ -113,6 +113,12 @@ var ( | |||
| Name: "enable-only-blinded-beacon-blocks", | |||
| Usage: "Enables storing only blinded beacon blocks in the database without full execution layer transactions", | |||
| } | |||
| enableEverythingOptimistic = &cli.BoolFlag{ | |||
| Name: "everything-optimistic", | |||
There was a problem hiding this comment.
How about?
Suggested change
| Name: "everything-optimistic", | |
| Name: "startup-optimistic", |
terencechain
previously approved these changes
Aug 24, 2022
terencechain
previously approved these changes
Aug 24, 2022
potuz
force-pushed
the
treat_everything_optimistic_flag
branch
from
05fcb3e to
059d4cf
Compare
potuz
force-pushed
the
treat_everything_optimistic_flag
branch
from
65dcc80 to
5c62692
Compare
terencechain
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a feature flag to treat every node as optimistic at launch. Currently this is essentially a noop, since the only node in forkchoice we do not revalidate is the finalized checkpoint. However this may be useful in case of an emergency when we implement sync from head.
Credit to @paulhauner for calling attention to this feature.