Arrange room for skirt and brim #9181
Conversation
…bject) Make the arrange function place objects so that the skirt and all the brims fit inside the bed.
I can't figure out how to make fff_print valid here so I decided to just reimplement the flow calculation.
|
Cool! |
|
That's super useful! Hope it gets merged soon! |
|
@rlesac Glad you like it. Unfortunately I haven't heard from Prusa at all. It has been months. I guess they are busy with other things. I'll just keep using it myself. shrug |
|
@tamasmeszaros Is this something you'd like to have in Prusa Slicer? I don't want to impose, but you seem to be the guy to ask about the arrange side of things. |
|
This is from the releasenotes for 2.6.0 alpha 6: |
|
@jmd73 Thank you for letting me know, I wasn't aware of this! |
|
Hi @individ-divided! as @jmd73 stated, this feature will be shipped with the next PS release, many thanks for your contributions. I will close this PR as unmerged, as there is no need for an explicit merge. I've tagged you alongside with @jschuh in the appropriate commits where your changes were used (directly or indirectly). |
Hello
I've changed the Arrange function so that it makes sure that any skirt or brim added also fits the bed. No longer does one press the arrange button and then after one slices, the skirt/brim is outside the bed!
I've contained the libnest2d changes so that they are backwards compatible with earlier versions, to make it easier to merge with upstream.
I believe these changes fixes #3477 and #3072
I wasn't aware of #7653 until a couple of minutes ago. The major difference is that these changes I made are capable of handling individual brim settings, per object. I also found out that thread safety issue (but on my own, why didn't I read this earlier!!) and implemented the flow calculations directly from the configuration, much like bubnikv suggested here
Best,
David