Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build_win.bat max version to Visual Studio 2022 #11646

Closed
wants to merge 1 commit into from

Conversation

jschuh
Copy link
Contributor

@jschuh jschuh commented Nov 12, 2023

No description provided.

@jschuh
Copy link
Contributor Author

jschuh commented Nov 12, 2023

@lukasmatena, do you mind approving this? I just updated the version and improved the comments/docs a bit.

@lukasmatena
Copy link
Collaborator

@jschuh Definitely. I will also update the "how to build on windows" guide, it contains a lot of outdated information which is no longer needed. Both changes will appear in the next release. Thanks a lot for the contribution.

Just for reference, this PR is a reaction to #11635.

@lukasmatena
Copy link
Collaborator

Merged. The commit will appear with the next release. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants