Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report Long Filename to Octoprint #2731

Closed
wants to merge 1 commit into from
Closed

Report Long Filename to Octoprint #2731

wants to merge 1 commit into from

Conversation

GilesBathgate
Copy link
Contributor

Uses the long filename when outputting the SD open filename so that Octoprint can display the long filename during monitoring.

@hergtoler
Report long filename for SD file opened
21f988d 
Allows Octopint to display long filename
@GilesBathgate GilesBathgate mentioned this pull request Jun 8, 2020
Closed
@BackSlasher
Copy link

BackSlasher commented Dec 21, 2020 •
edited
Loading

@leptun I see you approved #2669 which contains the same commit.
Could I ask you to please review this as well?

I'm an interested party :)
Thank you for your time!

leptun
leptun approved these changes Dec 21, 2020
View reviewed changes
Copy link
Collaborator

@leptun leptun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the first comment, I'm reapproving this PR.

@BackSlasher
Copy link

image
@leptun do we need someone else to approve?

@drbobbob drbobbob mentioned this pull request Dec 27, 2020
Closed
@neslekkim
Copy link

Won't spaces in filenames break the current behaviour on M20?, an parameter on M20 that returns a richer format instead?

@GilesBathgate
Copy link
Contributor Author

GilesBathgate commented Feb 6, 2021 •
edited
Loading

@neslekkim I think your comment is for #2934 This PR doesn't change the output of M20

@DRracer
Copy link
Collaborator

DRracer commented Apr 21, 2021

Could you please have a look at PR #3113 ? It should solve the long file names reporting and a bit more.
If you agree, can we close this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leptun leptun leptun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@GilesBathgate @BackSlasher @neslekkim @DRracer @leptun @hergtoler