gcode: Add Marlin / Octoprint SD card compatible behavior #3976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't check the accelerometer on XL before picking a tool. BFW-5689
The "Successfully connected to:" title text was truncated. BFW-5580
PhasesCrashRecovery::_last was not invalid :/ BFW-5690
This does not fully fix the issue, but should help it BFW-5645
The previous one was probably too permissive, possibly causing unwanted resumes. BFW-5645
Normally, this is not a problem. However, in the case that one of the unused extruder thermistor is broken and is reporting values below zero, the printer gets stuck in the reheating state. And yes, this actually happened. BFW-5657
Here's 50 B of flash for ya BFW-5686
-152 B flash BFW-5686
Duh. The problem is that the homeaxis_single_run reports axis as homed even though the homeaxis as a whole fails. This led to XY selftest not catching up the homing fail, resulting in a redscreen. BFW-5686
There were some left overs from where motor detection was part of Mk4 selftest - now handled by ScreenPrinterSetup. Also, add homing detection for all printers. We want to know if homing fails everywhere. BFW-5686
Testing did't like the red cross when you retry the test :P BFW-5686
BFW-5711
We need this to debug the gcode corruption. BFW-5714
BFW-5714
HWLIMIT_NORMAL_MAX_ACCELERATION was previouvly increased, but HWLIMIT_NORMAL_ACCELERATION was forgotten on the low values. BFW-5494 BFW-5644
BFW-5494 BFW-5644
This reverts commit b117f00.
Turns out product department doesn't want this after all.
Turns out product department doesn't want this after all.
It is not needed anymore after previous commits.
Marlin vars were incorrectly constructed instead of referencing the existing singleton, leading to using zero for time.
BFW-5858
Under some circumstances (plain-gcode file of the correct size), we could reach a situation where we do have the whole file downloaded, but the download itself is capable of providing some more data, therefore claims „Continue“. We would then first finalize the file and then continue the attempts to download it further, resulting in access to a null pointer. We could probably take more care of setting the range header more thoroughly in such situation, but the server can send more data anyway, so better protect us this way. BFW-5859.
As a result, don't ask for the 4th nozzle's diameter on MMU printer when printing from the 4th filament slot. BFW-5873.
If a file fails the valid for print check not because it is still not downloaded, but because it is somehow broken, report it as such. This goes all the way to the GUI, instead of the „Downloading“ screen. BFW-5830.
thess
force-pushed
the
Marlin-M2x-compat
branch
from
c5cf5fd to
9a19293
Compare
Implement M20 compatible with Marlin Align M23 & M24 compatibility with Marlin Add gcode M27 auto report support
thess
force-pushed
the
Marlin-M2x-compat
branch
from
9a19293 to
e2539e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds enough SD card gcode compatibility to list USB contents, including sub-directories, and start/stop/pause/resume printing from Octoprint or any other gcode serial interface application.
Addresses issue #3054
Alternative solution to #3765 (includes sub-directories and M23/M24 actually work)
Note: Installing the
BGCodeOctoprint plugin makes.bgcodefiles visible in the file listings. The entries can then be selected and printing started, etc. thus increasing the usability of Octoprint with the Buddy.