Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BFW-5624] Change to use Github issue templates #3298

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

murk-sy
Copy link
Contributor

@murk-sy murk-sy commented Sep 21, 2023

This change will reduce the amount of badly formatted bug reports and other issues submitted.

In addition to that, it will assure that text instructions for submitting the issue are not in every single issue, improving readability (in my mind at least). Not very useful to see a fairly long bug report only to see it's mostly default text left. Just search for Please attach a video. It usually helps to solve the problem. to see what I mean.

Major changes:

  • Links to support, knowledge base and forum have been added in the issue selection, as they are in the Prusaslicer repo as well (updated slightly)
  • Texts have been slightly massaged to differentiate enhancements and feature requests

Bug related:

  • "Original or custom firmware" was removed and a note was added next to firmware version to mention if it's modified firmware (should be fairly rare anyway and those using it will definitely know)
  • Instead of just "optional upgrades", modifications were also added, so users with perhaps custom extruders know to mention that
  • Various files have been condensed to a single field, with instructions added to zip non-image files.

Test issue submissions are visible on https://github.com/murk-sy/BFW-issueform/issues
("feature request" label should work despite not working in my fork)

I'm open to suggestions for improvements.

Possible changes:

  • remove [BUG] and other tags in the title text - is it necessary or are tags more relevant?
  • Add extra text just under the title for a concise description

@danopernis
Copy link
Member

danopernis commented Jun 3, 2024

Hi @murk-sy sorry for taking so long. This looks really nice. I looked into your repository and like how it works. Even if there might be some minor issues with certain fields or labels, these can be solved in different PRs and shouldn't prevent merging this.

Please resolve conflicts and whitespace errors and I will happily merge this!

@danopernis danopernis changed the title Change to use Github issue templates (beta) [BFW-5624] Change to use Github issue templates Jun 3, 2024
@murk-sy murk-sy closed this Jun 6, 2024
@murk-sy murk-sy reopened this Jun 6, 2024
@murk-sy
Copy link
Contributor Author

murk-sy commented Jun 6, 2024

Had a few problems with rebasing, so I had to do some extra stuff to get this back on track

Additionally, changed the bug text regarding crash dumps (they should now be sent by email)

Copy link
Member

@danopernis danopernis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the whitespace errors in order to fix Jenkins directly in your fork, didn't want to torture you with the git anymore. Merging...

@danopernis danopernis merged commit ce6d58b into prusa3d:master Jun 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants