Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sns): Add region to subscriptions #6731

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

jfagoagas
Copy link
Member

Description

Add region to SNS subscriptions.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jfagoagas jfagoagas requested review from a team as code owners January 29, 2025 15:27
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Jan 29, 2025
pedrooot
pedrooot previously approved these changes Jan 29, 2025
Copy link
Member

@pedrooot pedrooot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! 🔝

@jfagoagas jfagoagas added the backport-to-v5.2 Backport PR to the v5.2 branch label Jan 29, 2025
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.73%. Comparing base (545c2dc) to head (334ec43).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6731      +/-   ##
==========================================
- Coverage   93.70%   88.73%   -4.97%     
==========================================
  Files          67     1195    +1128     
  Lines        6351    34472   +28121     
==========================================
+ Hits         5951    30589   +24638     
- Misses        400     3883    +3483     
Flag Coverage Δ
api ?
prowler 88.73% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler 88.73% <100.00%> (∅)
api ∅ <ø> (∅)

@jfagoagas jfagoagas requested a review from pedrooot January 30, 2025 07:04
Copy link
Member

@pedrooot pedrooot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔝

@jfagoagas jfagoagas merged commit 5b57079 into master Jan 30, 2025
10 of 11 checks passed
@jfagoagas jfagoagas deleted the PRWLR-6128-add-region-to-sns-subscription branch January 30, 2025 08:53
@prowler-bot prowler-bot added the was-backported The PR was successfully backported to the target branch label Jan 30, 2025
@prowler-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
v5.2

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-v5.2 Backport PR to the v5.2 branch provider/aws Issues/PRs related with the AWS provider was-backported The PR was successfully backported to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants