Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gcp): fix flaky tests from dns service #6569

Merged

Conversation

danibarranqueroo
Copy link
Member

Context

Some tests from DNS are failing during some Github runnings. I've noticed that when the CheckReportGCP try to assign the region to the location of the report if the MagicMock object of the test does not have region it could fail, so I added that to all the tests of this service.

Description

Added dns_client.region to all the unit tests of the service DNS from GCP.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@danibarranqueroo danibarranqueroo requested review from a team as code owners January 16, 2025 18:44
@github-actions github-actions bot added the provider/gcp Issues/PRs related with the Google Cloud Platform provider label Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.45%. Comparing base (31c80a6) to head (9d46c6a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6569   +/-   ##
=======================================
  Coverage   89.45%   89.45%           
=======================================
  Files        1182     1182           
  Lines       33785    33785           
=======================================
+ Hits        30221    30222    +1     
+ Misses       3564     3563    -1     
Flag Coverage Δ
prowler 89.45% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler 89.45% <ø> (+<0.01%) ⬆️
api ∅ <ø> (∅)

@MrCloudSec MrCloudSec merged commit f041f17 into master Jan 16, 2025
11 checks passed
@MrCloudSec MrCloudSec deleted the PRWLR-5962-fix-flaky-tests-from-dns-service-in-gcp branch January 16, 2025 19:49
@MrCloudSec MrCloudSec added backport-to-v4.6 Backport PR to the v4.6 branch backport-to-v5.1 Backport PR to the v5.1 branch labels Jan 16, 2025
@prowler-bot prowler-bot added the was-backported The PR was successfully backported to the target branch label Jan 16, 2025
@prowler-bot
Copy link
Collaborator

💔 Some backports could not be created

Status Branch Result
v4.6 An unhandled error occurred. Please see the logs for details
v5.1

Manual backport

To create the backport manually run:

backport --pr 6569

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@prowler-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
v4.6
v5.1

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@prowler-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
v4.6
v5.1

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-v4.6 Backport PR to the v4.6 branch backport-to-v5.1 Backport PR to the v5.1 branch provider/gcp Issues/PRs related with the Google Cloud Platform provider was-backported The PR was successfully backported to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants